[Bf-blender-cvs] [95291466d5e] temp-vse-preview-transform2: Minor cleanup
Richard Antalik
noreply at git.blender.org
Wed Sep 15 17:19:54 CEST 2021
Commit: 95291466d5e30ee6c2f30bb1593b0b0436e6b9a9
Author: Richard Antalik
Date: Fri Sep 10 10:21:33 2021 +0200
Branches: temp-vse-preview-transform2
https://developer.blender.org/rB95291466d5e30ee6c2f30bb1593b0b0436e6b9a9
Minor cleanup
===================================================================
M source/blender/editors/space_sequencer/sequencer_draw.c
M source/blender/editors/space_sequencer/sequencer_select.c
M source/blender/makesrna/intern/rna_scene.c
===================================================================
diff --git a/source/blender/editors/space_sequencer/sequencer_draw.c b/source/blender/editors/space_sequencer/sequencer_draw.c
index c6c8d21512f..ef0979ee592 100644
--- a/source/blender/editors/space_sequencer/sequencer_draw.c
+++ b/source/blender/editors/space_sequencer/sequencer_draw.c
@@ -2210,7 +2210,6 @@ void sequencer_draw_preview(const bContext *C,
IMB_freeImBuf(ibuf);
}
- /* Image origins, may be only visible for development. */
SeqCollection *collection = Seq_query_rendered_strips(&scene->ed->seqbase, timeline_frame, 0);
Sequence *seq;
SEQ_ITERATOR_FOREACH (seq, collection) {
diff --git a/source/blender/editors/space_sequencer/sequencer_select.c b/source/blender/editors/space_sequencer/sequencer_select.c
index 819f4d457df..9e94d3eddd6 100644
--- a/source/blender/editors/space_sequencer/sequencer_select.c
+++ b/source/blender/editors/space_sequencer/sequencer_select.c
@@ -648,7 +648,7 @@ static bool seq_select_point_image_isect(const Scene *scene,
invert_m3(transform_matrix);
mul_m3_v2(transform_matrix, point);
- /* With rotation also translation is applied... This is garbage code... */
+ /* With rotation also translation is applied. Offset mouse position by same amount. */
point[0] += transform->xofs;
point[1] += transform->yofs;
@@ -676,7 +676,7 @@ static bool seq_select_point_image_isect(const Scene *scene,
return BLI_rctf_isect_pt(&r_rctf, point[0], point[1]);
}
-/* Tl;dr:
+/* Tl;dr: (XXX improve function and explain how it works)
* - get list of rendered seqs
* - for each unselected if click is in image boundary, return seq
* - else for each selected if click is in image boundary, return seq */
diff --git a/source/blender/makesrna/intern/rna_scene.c b/source/blender/makesrna/intern/rna_scene.c
index ea26ca8e3f2..a477b9b9b61 100644
--- a/source/blender/makesrna/intern/rna_scene.c
+++ b/source/blender/makesrna/intern/rna_scene.c
@@ -3526,10 +3526,8 @@ static void rna_def_sequencer_tool_settings(BlenderRNA *brna)
};
static const EnumPropertyItem pivot_points[] = {
- //{V3D_AROUND_CENTER_BOUNDS, "CENTER", ICON_PIVOT_BOUNDBOX, "Bounding Box Center", ""}, // Do we need this? (not implemented)
- // Is active element needed?
{V3D_AROUND_CENTER_MEDIAN, "MEDIAN", ICON_PIVOT_MEDIAN, "Median Point", ""},
- //{V3D_AROUND_CURSOR, "CURSOR", ICON_PIVOT_CURSOR, "2D Cursor", ""}, // TODO / Do we need this?
+ //{V3D_AROUND_CURSOR, "CURSOR", ICON_PIVOT_CURSOR, "2D Cursor", ""},
{V3D_AROUND_LOCAL_ORIGINS,
"INDIVIDUAL_ORIGINS",
ICON_PIVOT_INDIVIDUAL,
More information about the Bf-blender-cvs
mailing list