[Bf-blender-cvs] [319dcd351ed] cycles-x: Fix memory leak in Cycles X

Sergey Sharybin noreply at git.blender.org
Mon Sep 13 16:43:04 CEST 2021


Commit: 319dcd351edc871c37c5abda8ad99b19c70bf1db
Author: Sergey Sharybin
Date:   Mon Sep 13 16:41:18 2021 +0200
Branches: cycles-x
https://developer.blender.org/rB319dcd351edc871c37c5abda8ad99b19c70bf1db

Fix memory leak in Cycles X

Caused by recent refactor of tile file storage: need to take care of
freeing pass nodes.

===================================================================

M	intern/cycles/render/tile.cpp

===================================================================

diff --git a/intern/cycles/render/tile.cpp b/intern/cycles/render/tile.cpp
index c91ba36fd09..969724e3e9c 100644
--- a/intern/cycles/render/tile.cpp
+++ b/intern/cycles/render/tile.cpp
@@ -335,6 +335,11 @@ static bool configure_buffer_from_image_spec(BufferParams *buffer_params,
 
   buffer_params->update_passes(passes);
 
+  /* The base NodeOwner does not take ownership over nodes, so need to free passes explicitly. */
+  foreach (Pass *pass, passes) {
+    delete pass;
+  }
+
   return true;
 }



More information about the Bf-blender-cvs mailing list