[Bf-blender-cvs] [f77de678d89] master: EditMesh: recalculate normals after running rip

Campbell Barton noreply at git.blender.org
Thu Sep 2 03:47:20 CEST 2021


Commit: f77de678d89fe9e279cbb4228959955f42b007d3
Author: Campbell Barton
Date:   Thu Sep 2 11:42:18 2021 +1000
Branches: master
https://developer.blender.org/rBf77de678d89fe9e279cbb4228959955f42b007d3

EditMesh: recalculate normals after running rip

Failure to calculate normals caused an assertion since face
tessellation was being calculated with invalid normals.

In practice the rip-drag action would recalculate normals anyway,
however mesh tessellation should always be performed with valid normals.

===================================================================

M	source/blender/editors/mesh/editmesh_rip.c

===================================================================

diff --git a/source/blender/editors/mesh/editmesh_rip.c b/source/blender/editors/mesh/editmesh_rip.c
index 5a2a090b725..0553fa077f8 100644
--- a/source/blender/editors/mesh/editmesh_rip.c
+++ b/source/blender/editors/mesh/editmesh_rip.c
@@ -1085,7 +1085,7 @@ static int edbm_rip_invoke(bContext *C, wmOperator *op, const wmEvent *event)
     EDBM_update(obedit->data,
                 &(const struct EDBMUpdate_Params){
                     .calc_looptri = true,
-                    .calc_normals = false,
+                    .calc_normals = true,
                     .is_destructive = true,
                 });
   }



More information about the Bf-blender-cvs mailing list