[Bf-blender-cvs] [c107a3c4d9a] master: Fix invalid principled diffuse in Cycles OSL
Sergey Sharybin
noreply at git.blender.org
Tue Oct 19 12:38:55 CEST 2021
Commit: c107a3c4d9a540a287e21c517d353b670a71a0b5
Author: Sergey Sharybin
Date: Tue Oct 19 12:00:41 2021 +0200
Branches: master
https://developer.blender.org/rBc107a3c4d9a540a287e21c517d353b670a71a0b5
Fix invalid principled diffuse in Cycles OSL
Need to initialize components for the full Diffuse BSDF.
Steps to reproduce:
- Default cube scene
- Switch to Cycles renderer
- Enable OSL backend
- Start viewport render
- Observe cube being much black
Differential Revision: https://developer.blender.org/D12921
===================================================================
M intern/cycles/kernel/closure/bsdf_principled_diffuse.h
===================================================================
diff --git a/intern/cycles/kernel/closure/bsdf_principled_diffuse.h b/intern/cycles/kernel/closure/bsdf_principled_diffuse.h
index 6d25daa2356..74390f768a2 100644
--- a/intern/cycles/kernel/closure/bsdf_principled_diffuse.h
+++ b/intern/cycles/kernel/closure/bsdf_principled_diffuse.h
@@ -49,6 +49,7 @@ static_assert(sizeof(ShaderClosure) >= sizeof(PrincipledDiffuseBsdf),
ccl_device int bsdf_principled_diffuse_setup(ccl_private PrincipledDiffuseBsdf *bsdf)
{
bsdf->type = CLOSURE_BSDF_PRINCIPLED_DIFFUSE_ID;
+ bsdf->components = PRINCIPLED_DIFFUSE_FULL;
return SD_BSDF | SD_BSDF_HAS_EVAL;
}
More information about the Bf-blender-cvs
mailing list