[Bf-blender-cvs] [c1d138dd926] master: Fix T91979: Don't mark string nodes as supporting fields

Erik Abrahamsson noreply at git.blender.org
Tue Oct 19 02:08:22 CEST 2021


Commit: c1d138dd926c1d59be1a77576636cd72c512ab6a
Author: Erik Abrahamsson
Date:   Mon Oct 18 19:08:02 2021 -0500
Branches: master
https://developer.blender.org/rBc1d138dd926c1d59be1a77576636cd72c512ab6a

Fix T91979: Don't mark string nodes as supporting fields

Even though these nodes do support fields internally, there are no
input string sockets that support fields currently, so removing
the diamond sockets for now helps avoid confusion.

Differential Revision: https://developer.blender.org/D12828

===================================================================

M	source/blender/nodes/function/nodes/node_fn_string_length.cc
M	source/blender/nodes/function/nodes/node_fn_string_substring.cc
M	source/blender/nodes/function/nodes/node_fn_value_to_string.cc

===================================================================

diff --git a/source/blender/nodes/function/nodes/node_fn_string_length.cc b/source/blender/nodes/function/nodes/node_fn_string_length.cc
index 89038629c3c..a0f85dfd2bf 100644
--- a/source/blender/nodes/function/nodes/node_fn_string_length.cc
+++ b/source/blender/nodes/function/nodes/node_fn_string_length.cc
@@ -24,7 +24,6 @@ namespace blender::nodes {
 
 static void fn_node_string_length_declare(NodeDeclarationBuilder &b)
 {
-  b.is_function_node();
   b.add_input<decl::String>("String");
   b.add_output<decl::Int>("Length");
 };
diff --git a/source/blender/nodes/function/nodes/node_fn_string_substring.cc b/source/blender/nodes/function/nodes/node_fn_string_substring.cc
index b91171923d6..55a01093ae9 100644
--- a/source/blender/nodes/function/nodes/node_fn_string_substring.cc
+++ b/source/blender/nodes/function/nodes/node_fn_string_substring.cc
@@ -22,7 +22,6 @@ namespace blender::nodes {
 
 static void fn_node_string_substring_declare(NodeDeclarationBuilder &b)
 {
-  b.is_function_node();
   b.add_input<decl::String>("String");
   b.add_input<decl::Int>("Position");
   b.add_input<decl::Int>("Length").min(0);
diff --git a/source/blender/nodes/function/nodes/node_fn_value_to_string.cc b/source/blender/nodes/function/nodes/node_fn_value_to_string.cc
index 56206af2eb2..c1e6373cb6d 100644
--- a/source/blender/nodes/function/nodes/node_fn_value_to_string.cc
+++ b/source/blender/nodes/function/nodes/node_fn_value_to_string.cc
@@ -21,7 +21,6 @@ namespace blender::nodes {
 
 static void fn_node_value_to_string_declare(NodeDeclarationBuilder &b)
 {
-  b.is_function_node();
   b.add_input<decl::Float>("Value");
   b.add_input<decl::Int>("Decimals").min(0);
   b.add_output<decl::String>("String");



More information about the Bf-blender-cvs mailing list