[Bf-blender-cvs] [5c961b3b582] master: Revert "Fix T62325, T91990: changing Cycles presets does not update the Blender UI"

[Brecht Van Lommel]

Commit: 5c961b3b582f77f9f7e9fa99476217753c424d32
Author: Brecht Van Lommel
Date:   Sat Oct 16 13:54:29 2021 +0200
Branches: master
https://developer.blender.org/rB5c961b3b582f77f9f7e9fa99476217753c424d32

Revert "Fix T62325, T91990: changing Cycles presets does not update the Blender UI"

This reverts commit 1b6752e599b5ed70823d09f90c418e448516d4b4. It is causing
constant redraws due to some ID properties seemingly being edited on every
redraw.

===================================================================

M	source/blender/makesrna/intern/rna_access.c

===================================================================

diff --git a/source/blender/makesrna/intern/rna_access.c b/source/blender/makesrna/intern/rna_access.c
index 88c3db0c65b..40b5f3ed1da 100644
--- a/source/blender/makesrna/intern/rna_access.c
+++ b/source/blender/makesrna/intern/rna_access.c
@@ -2199,11 +2199,7 @@ static void rna_property_update(
  * but this isn't likely to be a performance problem. */
 bool RNA_property_update_check(PropertyRNA *prop)
 {
-  return
-      /* Always update ID properties. */
-      (prop->magic != RNA_MAGIC || (prop->flag & PROP_IDPROPERTY)) ||
-      /* For native RNA properties only update if there is a callback or notifier. */
-      (prop->update || prop->noteflag);
+  return (prop->magic != RNA_MAGIC || prop->update || prop->noteflag);
 }
 
 void RNA_property_update(bContext *C, PointerRNA *ptr, PropertyRNA *prop)