[Bf-blender-cvs] [988b9bc40ce] master: Fix T92192: Inconsistent curve circle primitive direction

Hans Goudey noreply at git.blender.org
Wed Oct 13 21:34:21 CEST 2021


Commit: 988b9bc40ce846cdce05961315dc0e2c1dd95e4b
Author: Hans Goudey
Date:   Wed Oct 13 14:34:14 2021 -0500
Branches: master
https://developer.blender.org/rB988b9bc40ce846cdce05961315dc0e2c1dd95e4b

Fix T92192: Inconsistent curve circle primitive direction

Switch sin and cosine so that the points in the circle have the same
direction in both radius and points modes.

===================================================================

M	source/blender/nodes/geometry/nodes/node_geo_curve_primitive_circle.cc

===================================================================

diff --git a/source/blender/nodes/geometry/nodes/node_geo_curve_primitive_circle.cc b/source/blender/nodes/geometry/nodes/node_geo_curve_primitive_circle.cc
index f5eb83ea4fd..efc2dff48c1 100644
--- a/source/blender/nodes/geometry/nodes/node_geo_curve_primitive_circle.cc
+++ b/source/blender/nodes/geometry/nodes/node_geo_curve_primitive_circle.cc
@@ -132,7 +132,7 @@ static std::unique_ptr<CurveEval> create_point_circle_curve(
      */
 
     const float theta = theta_step * i;
-    positions[i] = center + r * cos(theta) * v1 + r * sin(theta) * v4;
+    positions[i] = center + r * sin(theta) * v1 + r * cos(theta) * v4;
   }
 
   spline->radii().fill(1.0f);



More information about the Bf-blender-cvs mailing list