[Bf-blender-cvs] [e2755640c19] sculpt-dev: Sculpt: Allow non-manifold collapse

Joseph Eagar noreply at git.blender.org
Mon Oct 11 22:40:55 CEST 2021


Commit: e2755640c19ff81a1da0af4a8d4bd64c7b513aa6
Author: Joseph Eagar
Date:   Mon Oct 11 13:37:18 2021 -0700
Branches: sculpt-dev
https://developer.blender.org/rBe2755640c19ff81a1da0af4a8d4bd64c7b513aa6

Sculpt: Allow non-manifold collapse

* This was always buggy, which is why
  I have code that detects and snips off
  non-manifold fins.
* Turns out it is more robust to simply allow
  non-manifold collapses and clean up geometry
  afterwards.  IIRC this is how DynTopo (and the
  paper it's based off of) originall worked.

===================================================================

M	source/blender/blenkernel/intern/dyntopo.c

===================================================================

diff --git a/source/blender/blenkernel/intern/dyntopo.c b/source/blender/blenkernel/intern/dyntopo.c
index e92f48e817b..7a789285f05 100644
--- a/source/blender/blenkernel/intern/dyntopo.c
+++ b/source/blender/blenkernel/intern/dyntopo.c
@@ -3739,7 +3739,7 @@ static void pbvh_bmesh_collapse_edge(PBVH *pbvh,
   }
 
   if (bm_edge_collapse_is_degenerate_topology(e)) {
-    return;
+    // return;
   }
 
   pbvh_check_vert_boundary(pbvh, v1);



More information about the Bf-blender-cvs mailing list