[Bf-blender-cvs] [98fe05fb5b9] master: Fix T91810 Bevel not working well with certain unbeveled edge positions.

Howard Trickey noreply at git.blender.org
Sun Oct 3 17:33:19 CEST 2021


Commit: 98fe05fb5b9e1e2ee184444ff56806fa66de2615
Author: Howard Trickey
Date:   Sun Oct 3 11:26:48 2021 -0400
Branches: master
https://developer.blender.org/rB98fe05fb5b9e1e2ee184444ff56806fa66de2615

Fix T91810 Bevel not working well with certain unbeveled edge positions.

A previous commit, c56526d8b68ab, which sometimes didn't drop offsets
into 'in plane' faces, as a fix to T71329, was overly aggressive.
If all the intermediate edges are in the same plane then it is fine
to just put the meeting point on the plane of the start and end edges.

===================================================================

M	source/blender/bmesh/tools/bmesh_bevel.c

===================================================================

diff --git a/source/blender/bmesh/tools/bmesh_bevel.c b/source/blender/bmesh/tools/bmesh_bevel.c
index 1f759e9ef43..8bd498a08bd 100644
--- a/source/blender/bmesh/tools/bmesh_bevel.c
+++ b/source/blender/bmesh/tools/bmesh_bevel.c
@@ -3048,7 +3048,9 @@ static void build_boundary(BevelParams *bp, BevVert *bv, bool construct)
         }
       }
       else {
-        offset_meet(bp, e, e2, bv->v, e->fnext, true, co, eip);
+        /* Since all edges between e and e2 are in the same plane, it is OK
+         * to treat this like the case where there are no edges between. */
+        offset_meet(bp, e, e2, bv->v, e->fnext, false, co, NULL);
       }
     }



More information about the Bf-blender-cvs mailing list