[Bf-blender-cvs] [eb3a8fb4e8b] master: Fix T91872: incorrect socket inspection on group nodes

Jacques Lucke noreply at git.blender.org
Fri Oct 1 13:21:22 CEST 2021


Commit: eb3a8fb4e8b173edc2282f6462e219ab8b9c95e2
Author: Jacques Lucke
Date:   Fri Oct 1 13:20:46 2021 +0200
Branches: master
https://developer.blender.org/rBeb3a8fb4e8b173edc2282f6462e219ab8b9c95e2

Fix T91872: incorrect socket inspection on group nodes

This bug was introduced in rBef45399f3be0955ba8.

===================================================================

M	source/blender/editors/space_node/node_draw.cc

===================================================================

diff --git a/source/blender/editors/space_node/node_draw.cc b/source/blender/editors/space_node/node_draw.cc
index 499ccb8a889..9b243290566 100644
--- a/source/blender/editors/space_node/node_draw.cc
+++ b/source/blender/editors/space_node/node_draw.cc
@@ -1109,13 +1109,13 @@ static void node_socket_draw_nested(const bContext *C,
           if (!description.is_empty()) {
             output << TIP_(description.data()) << ".\n\n";
           }
-
-          if (socket_inspection_str.has_value()) {
-            output << *socket_inspection_str;
-            return BLI_strdup(output.str().c_str());
-          }
         }
-        output << TIP_("The socket value has not been computed yet");
+        if (socket_inspection_str.has_value()) {
+          output << *socket_inspection_str;
+        }
+        else {
+          output << TIP_("The socket value has not been computed yet");
+        }
         return BLI_strdup(output.str().c_str());
       },
       data,



More information about the Bf-blender-cvs mailing list