[Bf-blender-cvs] [bdb7d262aad] master: Cleanup: clang-tidy warnings

[Campbell Barton]

Commit: bdb7d262aadb2685f0cb7ef73840e479252e70d4
Author: Campbell Barton
Date:   Fri Oct 1 16:20:31 2021 +1000
Branches: master
https://developer.blender.org/rBbdb7d262aadb2685f0cb7ef73840e479252e70d4

Cleanup: clang-tidy warnings

===================================================================

M	source/blender/blenkernel/intern/asset_catalog_path.cc
M	source/blender/imbuf/intern/openexr/openexr_stub.cpp
M	source/blender/sequencer/intern/modifier.c

===================================================================

diff --git a/source/blender/blenkernel/intern/asset_catalog_path.cc b/source/blender/blenkernel/intern/asset_catalog_path.cc
index cc6aceef8e7..022bceb133e 100644
--- a/source/blender/blenkernel/intern/asset_catalog_path.cc
+++ b/source/blender/blenkernel/intern/asset_catalog_path.cc
@@ -38,9 +38,7 @@ AssetCatalogPath::AssetCatalogPath(const char *path) : path_(path)
 {
 }
 
-AssetCatalogPath::AssetCatalogPath(const AssetCatalogPath &other_path) : path_(other_path.path_)
-{
-}
+AssetCatalogPath::AssetCatalogPath(const AssetCatalogPath &other_path) = default;
 
 AssetCatalogPath::AssetCatalogPath(AssetCatalogPath &&other_path) noexcept
     : path_(std::move(other_path.path_))
diff --git a/source/blender/imbuf/intern/openexr/openexr_stub.cpp b/source/blender/imbuf/intern/openexr/openexr_stub.cpp
index 639100ac6fe..9b4d6178613 100644
--- a/source/blender/imbuf/intern/openexr/openexr_stub.cpp
+++ b/source/blender/imbuf/intern/openexr/openexr_stub.cpp
@@ -49,7 +49,7 @@ bool IMB_exr_begin_read(void * /*handle*/,
                         int * /*height*/,
                         const bool /*add_channels*/)
 {
-  return 0;
+  return false;
 }
 bool IMB_exr_begin_write(void * /*handle*/,
                          const char * /*filename*/,
diff --git a/source/blender/sequencer/intern/modifier.c b/source/blender/sequencer/intern/modifier.c
index 8414599b225..1a63f4c4655 100644
--- a/source/blender/sequencer/intern/modifier.c
+++ b/source/blender/sequencer/intern/modifier.c
@@ -302,9 +302,8 @@ static StripColorBalance calc_cb(StripColorBalance *cb_)
   if (cb_->method == SEQ_COLOR_BALANCE_METHOD_LIFTGAMMAGAIN) {
     return calc_cb_lgg(cb_);
   }
-  else { /* cb_->method == SEQ_COLOR_BALANCE_METHOD_SLOPEOFFSETPOWER */
-    return calc_cb_sop(cb_);
-  }
+  /* `cb_->method == SEQ_COLOR_BALANCE_METHOD_SLOPEOFFSETPOWER`. */
+  return calc_cb_sop(cb_);
 }
 
 /* NOTE: lift is actually 2-lift. */