[Bf-blender-cvs] [06242359008] master: Moviecache: Fix potential memory corruption.

Jeroen Bakker noreply at git.blender.org
Mon Nov 22 15:52:46 CET 2021


Commit: 06242359008f0adb1d8330f5253e208a6779fe0d
Author: Jeroen Bakker
Date:   Mon Nov 22 15:52:15 2021 +0100
Branches: master
https://developer.blender.org/rB06242359008f0adb1d8330f5253e208a6779fe0d

Moviecache: Fix potential memory corruption.

`IMB_moviecache` is implemented as a singleton. When destructing the
singleton via `IMB_moviecache_destruct` it will not be created anymore
resulting inusage of unallocated memory and potentional memory
corruption.

When running blender this doesn't happen, but when creating images in
test cases the moviecache should be able to be recreated after it is
destroyed.

Reviewed By: sergey

Differential Revision: https://developer.blender.org/D13287

===================================================================

M	source/blender/imbuf/intern/moviecache.c

===================================================================

diff --git a/source/blender/imbuf/intern/moviecache.c b/source/blender/imbuf/intern/moviecache.c
index 8923ba98e08..773a3486233 100644
--- a/source/blender/imbuf/intern/moviecache.c
+++ b/source/blender/imbuf/intern/moviecache.c
@@ -268,6 +268,7 @@ void IMB_moviecache_destruct(void)
 {
   if (limitor) {
     delete_MEM_CacheLimiter(limitor);
+    limitor = NULL;
   }
 }



More information about the Bf-blender-cvs mailing list