[Bf-blender-cvs] [1222c455446] master: Fix: Use the instances domain in instance transform nodes

Hans Goudey noreply at git.blender.org
Fri Nov 19 18:26:55 CET 2021


Commit: 1222c45544637ae6255935db14f3e0e23fc63cf3
Author: Hans Goudey
Date:   Fri Nov 19 12:26:48 2021 -0500
Branches: master
https://developer.blender.org/rB1222c45544637ae6255935db14f3e0e23fc63cf3

Fix: Use the instances domain in instance transform nodes

Instance attributes exist on the instance domain after rB97533eede44421,
so these fields should be evaluated on that domain.

===================================================================

M	source/blender/nodes/geometry/nodes/node_geo_rotate_instances.cc
M	source/blender/nodes/geometry/nodes/node_geo_scale_instances.cc
M	source/blender/nodes/geometry/nodes/node_geo_translate_instances.cc

===================================================================

diff --git a/source/blender/nodes/geometry/nodes/node_geo_rotate_instances.cc b/source/blender/nodes/geometry/nodes/node_geo_rotate_instances.cc
index abf44b1aaf8..c53eaa2ded9 100644
--- a/source/blender/nodes/geometry/nodes/node_geo_rotate_instances.cc
+++ b/source/blender/nodes/geometry/nodes/node_geo_rotate_instances.cc
@@ -32,7 +32,7 @@ static void geo_node_rotate_instances_declare(NodeDeclarationBuilder &b)
 
 static void rotate_instances(GeoNodeExecParams &params, InstancesComponent &instances_component)
 {
-  GeometryComponentFieldContext field_context{instances_component, ATTR_DOMAIN_POINT};
+  GeometryComponentFieldContext field_context{instances_component, ATTR_DOMAIN_INSTANCE};
   const int domain_size = instances_component.instances_amount();
 
   fn::FieldEvaluator selection_evaluator{field_context, domain_size};
diff --git a/source/blender/nodes/geometry/nodes/node_geo_scale_instances.cc b/source/blender/nodes/geometry/nodes/node_geo_scale_instances.cc
index ea2b458410e..fa2501515a9 100644
--- a/source/blender/nodes/geometry/nodes/node_geo_scale_instances.cc
+++ b/source/blender/nodes/geometry/nodes/node_geo_scale_instances.cc
@@ -35,7 +35,7 @@ static void geo_node_scale_instances_declare(NodeDeclarationBuilder &b)
 
 static void scale_instances(GeoNodeExecParams &params, InstancesComponent &instances_component)
 {
-  GeometryComponentFieldContext field_context{instances_component, ATTR_DOMAIN_POINT};
+  GeometryComponentFieldContext field_context{instances_component, ATTR_DOMAIN_INSTANCE};
 
   fn::FieldEvaluator selection_evaluator{field_context, instances_component.instances_amount()};
   selection_evaluator.add(params.extract_input<Field<bool>>("Selection"));
diff --git a/source/blender/nodes/geometry/nodes/node_geo_translate_instances.cc b/source/blender/nodes/geometry/nodes/node_geo_translate_instances.cc
index fa05d858a07..1a5a60fb1b0 100644
--- a/source/blender/nodes/geometry/nodes/node_geo_translate_instances.cc
+++ b/source/blender/nodes/geometry/nodes/node_geo_translate_instances.cc
@@ -31,7 +31,7 @@ static void geo_node_translate_instances_declare(NodeDeclarationBuilder &b)
 
 static void translate_instances(GeoNodeExecParams &params, InstancesComponent &instances_component)
 {
-  GeometryComponentFieldContext field_context{instances_component, ATTR_DOMAIN_POINT};
+  GeometryComponentFieldContext field_context{instances_component, ATTR_DOMAIN_INSTANCE};
 
   fn::FieldEvaluator selection_evaluator{field_context, instances_component.instances_amount()};
   selection_evaluator.add(params.extract_input<Field<bool>>("Selection"));



More information about the Bf-blender-cvs mailing list