[Bf-blender-cvs] [b5162638c58] blender-v3.0-release: Fix: Geometry Nodes: Math node smoothmax not working

Charlie Jolly noreply at git.blender.org
Thu Nov 4 14:41:36 CET 2021


Commit: b5162638c58397f32e766882fa101ab683f455a5
Author: Charlie Jolly
Date:   Thu Nov 4 13:40:38 2021 +0000
Branches: blender-v3.0-release
https://developer.blender.org/rBb5162638c58397f32e766882fa101ab683f455a5

Fix: Geometry Nodes: Math node smoothmax not working

Function arguments were incorrect.

Noted during @simonthommes live stream.

Reviewed By: JacquesLucke

Differential Revision: https://developer.blender.org/D13110

===================================================================

M	source/blender/nodes/NOD_math_functions.hh

===================================================================

diff --git a/source/blender/nodes/NOD_math_functions.hh b/source/blender/nodes/NOD_math_functions.hh
index 9443be820d1..86ff8cab3e9 100644
--- a/source/blender/nodes/NOD_math_functions.hh
+++ b/source/blender/nodes/NOD_math_functions.hh
@@ -193,7 +193,7 @@ inline bool try_dispatch_float_math_fl_fl_fl_to_fl(const int operation, Callback
     case NODE_MATH_SMOOTH_MIN:
       return dispatch([](float a, float b, float c) { return smoothminf(a, b, c); });
     case NODE_MATH_SMOOTH_MAX:
-      return dispatch([](float a, float b, float c) { return -smoothminf(-a, -b, -c); });
+      return dispatch([](float a, float b, float c) { return -smoothminf(-a, -b, c); });
     case NODE_MATH_WRAP:
       return dispatch([](float a, float b, float c) { return wrapf(a, b, c); });
   }



More information about the Bf-blender-cvs mailing list