[Bf-blender-cvs] [d5c3bff6e77] blender-v2.93-release: Fix T87357: Missing update after removing socket
Jacques Lucke
noreply at git.blender.org
Fri May 21 20:43:59 CEST 2021
Commit: d5c3bff6e77466fd6f12bd8f71a3e40b5ce43c99
Author: Jacques Lucke
Date: Fri May 21 14:43:26 2021 -0400
Branches: blender-v2.93-release
https://developer.blender.org/rBd5c3bff6e77466fd6f12bd8f71a3e40b5ce43c99
Fix T87357: Missing update after removing socket
The CoW copy of the node group was not updated correctly after it
changed. Arguably, tagging the node tree could also be part of
`ntreeUpdateTree` (which needs to be called after changes to the
node tree anyway). However, there are many instances where the
depsgraph is tagged explicitly after `ntreeUpdateTree` is called,
so it should be fine here as well. This is similar to what is done
in `snode_dag_update`.
Differential Revision: https://developer.blender.org/D11342
===================================================================
M source/blender/makesrna/intern/rna_nodetree.c
===================================================================
diff --git a/source/blender/makesrna/intern/rna_nodetree.c b/source/blender/makesrna/intern/rna_nodetree.c
index b0254ce2ef3..b1b2e9738c1 100644
--- a/source/blender/makesrna/intern/rna_nodetree.c
+++ b/source/blender/makesrna/intern/rna_nodetree.c
@@ -1378,6 +1378,7 @@ static void rna_NodeTree_socket_remove(bNodeTree *ntree,
ntreeRemoveSocketInterface(ntree, sock);
ntreeUpdateTree(bmain, ntree);
+ DEG_id_tag_update(&ntree->id, 0);
WM_main_add_notifier(NC_NODE | NA_EDITED, ntree);
}
}
More information about the Bf-blender-cvs
mailing list