[Bf-blender-cvs] [15558094803] blender-v2.83-release: Fix memory leak in Python IDproperty iterator
Campbell Barton
noreply at git.blender.org
Fri May 21 08:14:29 CEST 2021
Commit: 1555809480304b0790f22512b363619d302ec007
Author: Campbell Barton
Date: Tue May 11 11:13:28 2021 +1000
Branches: blender-v2.83-release
https://developer.blender.org/rB1555809480304b0790f22512b363619d302ec007
Fix memory leak in Python IDproperty iterator
Looping over IDProperty keys or calling iteritems leaked memory.
Error in original Python idproperty support from
8768707610fbc1cea2bde069cdfd6d3f3e2fc522
===================================================================
M source/blender/python/generic/idprop_py_api.c
===================================================================
diff --git a/source/blender/python/generic/idprop_py_api.c b/source/blender/python/generic/idprop_py_api.c
index cabeeba18b9..a183de6623f 100644
--- a/source/blender/python/generic/idprop_py_api.c
+++ b/source/blender/python/generic/idprop_py_api.c
@@ -764,7 +764,6 @@ static PyObject *BPy_IDGroup_iter(BPy_IDProperty *self)
iter->group = self;
iter->mode = IDPROP_ITER_KEYS;
iter->cur = self->prop->data.group.first;
- Py_XINCREF(iter);
return (PyObject *)iter;
}
@@ -937,7 +936,6 @@ static PyObject *BPy_IDGroup_iter_items(BPy_IDProperty *self)
iter->group = self;
iter->mode = IDPROP_ITER_ITEMS;
iter->cur = self->prop->data.group.first;
- Py_XINCREF(iter);
return (PyObject *)iter;
}
More information about the Bf-blender-cvs
mailing list