[Bf-blender-cvs] [5aee4ba1433] blender-v2.93-release: Fix memory leak in Python IDproperty iterator

[Campbell Barton]

Commit: 5aee4ba1433094e586ef873de734ae90f1622c0f
Author: Campbell Barton
Date:   Tue May 11 11:13:28 2021 +1000
Branches: blender-v2.93-release
https://developer.blender.org/rB5aee4ba1433094e586ef873de734ae90f1622c0f

Fix memory leak in Python IDproperty iterator

Looping over IDProperty keys or calling iteritems leaked memory.

Error in original Python idproperty support from
8768707610fbc1cea2bde069cdfd6d3f3e2fc522

===================================================================

M	source/blender/python/generic/idprop_py_api.c

===================================================================

diff --git a/source/blender/python/generic/idprop_py_api.c b/source/blender/python/generic/idprop_py_api.c
index c329ea7965c..88abae39e2a 100644
--- a/source/blender/python/generic/idprop_py_api.c
+++ b/source/blender/python/generic/idprop_py_api.c
@@ -760,7 +760,6 @@ static PyObject *BPy_IDGroup_iter(BPy_IDProperty *self)
   iter->group = self;
   iter->mode = IDPROP_ITER_KEYS;
   iter->cur = self->prop->data.group.first;
-  Py_XINCREF(iter);
   return (PyObject *)iter;
 }
 
@@ -933,7 +932,6 @@ static PyObject *BPy_IDGroup_iter_items(BPy_IDProperty *self)
   iter->group = self;
   iter->mode = IDPROP_ITER_ITEMS;
   iter->cur = self->prop->data.group.first;
-  Py_XINCREF(iter);
   return (PyObject *)iter;
 }