[Bf-blender-cvs] [7904899d022] master: Gpencil - Fix stroke normal from D10171

Cody Winchester noreply at git.blender.org
Tue May 4 16:31:20 CEST 2021


Commit: 7904899d0222d94dc1b5ea9b32b6c0986e2fedff
Author: Cody Winchester
Date:   Tue May 4 16:30:37 2021 +0200
Branches: master
https://developer.blender.org/rB7904899d0222d94dc1b5ea9b32b6c0986e2fedff

Gpencil - Fix stroke normal from D10171

In my previous patch https://developer.blender.org/D10171 some code changing the direction the strokes normal was accidentally included. This patch reverts that back to the original normal calculation.

Reviewed By: #grease_pencil, antoniov

Differential Revision: https://developer.blender.org/D11148

===================================================================

M	source/blender/blenkernel/intern/gpencil_geom.c

===================================================================

diff --git a/source/blender/blenkernel/intern/gpencil_geom.c b/source/blender/blenkernel/intern/gpencil_geom.c
index 612bfe65f34..04403e264a4 100644
--- a/source/blender/blenkernel/intern/gpencil_geom.c
+++ b/source/blender/blenkernel/intern/gpencil_geom.c
@@ -1688,7 +1688,6 @@ void BKE_gpencil_stroke_normal(const bGPDstroke *gps, float r_normal[3])
 
   float vec1[3];
   float vec2[3];
-  float vec3[3];
 
   /* initial vector (p0 -> p1) */
   sub_v3_v3v3(vec1, &pt1->x, &pt0->x);
@@ -1697,8 +1696,7 @@ void BKE_gpencil_stroke_normal(const bGPDstroke *gps, float r_normal[3])
   sub_v3_v3v3(vec2, &pt3->x, &pt0->x);
 
   /* vector orthogonal to polygon plane */
-  cross_v3_v3v3(vec3, vec1, vec2);
-  cross_v3_v3v3(r_normal, vec1, vec3);
+  cross_v3_v3v3(r_normal, vec1, vec2);
 
   /* Normalize vector */
   normalize_v3(r_normal);



More information about the Bf-blender-cvs mailing list