[Bf-blender-cvs] [d05413b91b5] asset-browser-poselib: Fix possible use of released stack memory

[Julian Eisel]

Commit: d05413b91b5d2a160a7b08ea7c70ad2ccb5dc0c0
Author: Julian Eisel
Date:   Wed Mar 31 16:00:49 2021 +0200
Branches: asset-browser-poselib
https://developer.blender.org/rBd05413b91b5d2a160a7b08ea7c70ad2ccb5dc0c0

Fix possible use of released stack memory

We'd store references to temporary objects, e.g. see
`AssetListStorage::ensure_list_storage()`. Stupid mistake, store a copy
of the `AssetLibraryReference` struct now (cheap to copy).

===================================================================

M	source/blender/editors/asset/asset_list.cc

===================================================================

diff --git a/source/blender/editors/asset/asset_list.cc b/source/blender/editors/asset/asset_list.cc
index c2be9f6e2d9..eda16be1e50 100644
--- a/source/blender/editors/asset/asset_list.cc
+++ b/source/blender/editors/asset/asset_list.cc
@@ -57,7 +57,7 @@ using namespace blender;
  * Wrapper to add logic to the AssetLibraryReference DNA struct.
  */
 class AssetLibraryReferenceWrapper {
-  const AssetLibraryReference &reference_;
+  const AssetLibraryReference reference_;
 
  public:
   /* Intentionally not `explicit`, allow implicit conversion for convienience. Might have to be