[Bf-blender-cvs] [19f1c522696] master: Cleanup: Remove no-op id recalc statement

Sergey Sharybin noreply at git.blender.org
Mon Mar 29 11:46:14 CEST 2021


Commit: 19f1c522696088e9247288abc24bd69b047e52ff
Author: Sergey Sharybin
Date:   Mon Mar 29 11:23:35 2021 +0200
Branches: master
https://developer.blender.org/rB19f1c522696088e9247288abc24bd69b047e52ff

Cleanup: Remove no-op id recalc statement

Initially this is a typo when solving merge conflict back in 2017
in commit rBf4140f2c8138.

The code was so for 3 years, so it is safer to assume that this is
the new expected design. The affected codepath only comes from the
BKE_object_modifier_update_subframe() which is discouraged from use
and have other issues.

Eventually those offending codepaths will be removed completely.

The grade-schema for now is more localized: remove ID_RECALC_ALL
which seems to be misused and is causing issues like the ones which
are described and discussed in T81340.

On user level there should be no measurable changes. In fact, no
functional changes at all are expected to happen.

Reviewed By: sybren

Differential Revision: https://developer.blender.org/D9220

===================================================================

M	source/blender/blenkernel/intern/object.c

===================================================================

diff --git a/source/blender/blenkernel/intern/object.c b/source/blender/blenkernel/intern/object.c
index a8224094919..8c5a4966633 100644
--- a/source/blender/blenkernel/intern/object.c
+++ b/source/blender/blenkernel/intern/object.c
@@ -4353,8 +4353,6 @@ void BKE_object_handle_update_ex(Depsgraph *depsgraph,
     BKE_object_handle_data_update(depsgraph, scene, ob);
   }
 
-  ob->id.recalc &= ID_RECALC_ALL;
-
   object_handle_update_proxy(depsgraph, scene, ob, do_proxy_update);
 }



More information about the Bf-blender-cvs mailing list