[Bf-blender-cvs] [2a06657eca5] master: Cleanup: Don't use class method to override equality operator

Hans Goudey noreply at git.blender.org
Mon Mar 22 01:21:14 CET 2021


Commit: 2a06657eca5a9b217384062daf55343bf08f86ec
Author: Hans Goudey
Date:   Sun Mar 21 20:21:05 2021 -0400
Branches: master
https://developer.blender.org/rB2a06657eca5a9b217384062daf55343bf08f86ec

Cleanup: Don't use class method to override equality operator

This won't make a difference in this case, but it's consider better
practice since there is no vagueness about implicit conversion.

===================================================================

M	source/blender/blenkernel/BKE_node_ui_storage.hh

===================================================================

diff --git a/source/blender/blenkernel/BKE_node_ui_storage.hh b/source/blender/blenkernel/BKE_node_ui_storage.hh
index be9510179c3..a8fdbec1e8c 100644
--- a/source/blender/blenkernel/BKE_node_ui_storage.hh
+++ b/source/blender/blenkernel/BKE_node_ui_storage.hh
@@ -63,10 +63,10 @@ class NodeTreeEvaluationContext {
     return hash1 ^ (hash2 * 33); /* Copied from DefaultHash for std::pair. */
   }
 
-  bool operator==(const NodeTreeEvaluationContext &other) const
+  friend bool operator==(const NodeTreeEvaluationContext &a, const NodeTreeEvaluationContext &b)
   {
-    return other.object_name_ == object_name_ &&
-           BLI_session_uuid_is_equal(&other.modifier_session_uuid_, &modifier_session_uuid_);
+    return a.object_name_ == b.object_name_ &&
+           BLI_session_uuid_is_equal(&a.modifier_session_uuid_, &b.modifier_session_uuid_);
   }
 };



More information about the Bf-blender-cvs mailing list