[Bf-blender-cvs] [3b28a68d97e] ui-asset-view-template: Fix T86677: select grouped in node editor crashes without active node

Philipp Oeser noreply at git.blender.org
Sun Mar 21 16:11:59 CET 2021


Commit: 3b28a68d97e04e0a19c78e046e5cdc0f6cd3aea3
Author: Philipp Oeser
Date:   Thu Mar 18 16:47:14 2021 +0100
Branches: ui-asset-view-template
https://developer.blender.org/rB3b28a68d97e04e0a19c78e046e5cdc0f6cd3aea3

Fix T86677: select grouped in node editor crashes without active node

This was reported for geometry nodes, but was true for all nodetrees
(e.g. after deleting the active node). Geometry node trees just made
this more obvious since they start without an active node to begin with.

Fix provided by @lone_noel, thx!

Maniphest Tasks: T86677

Differential Revision: https://developer.blender.org/D10762

===================================================================

M	source/blender/editors/space_node/node_select.c

===================================================================

diff --git a/source/blender/editors/space_node/node_select.c b/source/blender/editors/space_node/node_select.c
index 704b7350bb9..1da79671c8e 100644
--- a/source/blender/editors/space_node/node_select.c
+++ b/source/blender/editors/space_node/node_select.c
@@ -370,6 +370,11 @@ static int node_select_grouped_exec(bContext *C, wmOperator *op)
 {
   SpaceNode *snode = CTX_wm_space_node(C);
   bNode *node_act = nodeGetActive(snode->edittree);
+
+  if (node_act == NULL) {
+    return OPERATOR_CANCELLED;
+  }
+
   bNode *node;
   bool changed = false;
   const bool extend = RNA_boolean_get(op->ptr, "extend");



More information about the Bf-blender-cvs mailing list