[Bf-blender-cvs] [1f7140e7095] master: Tracking: Mention TODO about DNA to Libmv API conversion

[Sergey Sharybin]

Commit: 1f7140e70955b2fbbea7a2fc6307c471c95f243e
Author: Sergey Sharybin
Date:   Mon Mar 15 15:16:10 2021 +0100
Branches: master
https://developer.blender.org/rB1f7140e70955b2fbbea7a2fc6307c471c95f243e

Tracking: Mention TODO about DNA to Libmv API conversion

Current code works, but is heavily relying on matched enum definition
in the Blender's DNA and Libmv's API, which is suboptimal and fragile.

===================================================================

M	source/blender/blenkernel/intern/tracking_region_tracker.c

===================================================================

diff --git a/source/blender/blenkernel/intern/tracking_region_tracker.c b/source/blender/blenkernel/intern/tracking_region_tracker.c
index 7e37e438e24..68e866b355d 100644
--- a/source/blender/blenkernel/intern/tracking_region_tracker.c
+++ b/source/blender/blenkernel/intern/tracking_region_tracker.c
@@ -185,6 +185,8 @@ void tracking_configure_tracker(const MovieTrackingTrack *track,
                                 float *mask,
                                 libmv_TrackRegionOptions *options)
 {
+  /* TODO(sergey): Use explicit conversion, so that options are decoupled between the Libmv library
+   * and enumerator values in DNA. */
   options->motion_model = track->motion_model;
 
   options->use_brute = ((track->algorithm_flag & TRACK_ALGORITHM_FLAG_USE_BRUTE) != 0);