[Bf-blender-cvs] [92ed7f3872a] usd-importer-T81257-merge: USD Import: USDPrimReader uninitialized members.

makowalski noreply at git.blender.org
Fri Mar 5 03:50:27 CET 2021


Commit: 92ed7f3872abbf8bcbc227ad8e68ffa5fa731843
Author: makowalski
Date:   Thu Mar 4 21:43:57 2021 -0500
Branches: usd-importer-T81257-merge
https://developer.blender.org/rB92ed7f3872abbf8bcbc227ad8e68ffa5fa731843

USD Import: USDPrimReader uninitialized members.

Fixed bug where several USDPrimReader class member variables
were not being intialized in the constructor.  One of the
previously uninitialized variables stores the reference count,
which was causing memory leaks in some cases.

===================================================================

M	source/blender/io/usd/intern/usd_reader_prim.cc

===================================================================

diff --git a/source/blender/io/usd/intern/usd_reader_prim.cc b/source/blender/io/usd/intern/usd_reader_prim.cc
index bdf96be1d31..739bce2d2f3 100644
--- a/source/blender/io/usd/intern/usd_reader_prim.cc
+++ b/source/blender/io/usd/intern/usd_reader_prim.cc
@@ -42,10 +42,13 @@ USDPrimReader::USDPrimReader(pxr::UsdStageRefPtr stage,
                              ImportSettings &settings)
     : m_name(object.GetName().GetString()),
       m_prim_path(object.GetPrimPath().GetString()),
+      m_object(nullptr),
       m_prim(object),
       m_stage(stage),
       m_import_params(import_params),
-      m_settings(&settings)
+      m_parent_reader(nullptr),
+      m_settings(&settings),
+      m_refcount(0)
 {
   //@TODO(bjs): This should be handled better
   if (m_name == "/")



More information about the Bf-blender-cvs mailing list