[Bf-blender-cvs] [8bfdec76c04] tmp-vulkan: Vulkan: Fix uninitialized ram in VKTexture

Ray Molenkamp noreply at git.blender.org
Wed Jun 30 18:53:06 CEST 2021


Commit: 8bfdec76c04c6c74fd19b7ec0dd2c54e21da527c
Author: Ray Molenkamp
Date:   Wed Jun 30 10:53:00 2021 -0600
Branches: tmp-vulkan
https://developer.blender.org/rB8bfdec76c04c6c74fd19b7ec0dd2c54e21da527c

Vulkan: Fix uninitialized ram in VKTexture

The ram being uninitialised caused issues in
VKTexture's destructor which tests for
VK_NULL_HANDLE. The nvidia driver did not
enjoy being fed a bogus pointer and crashed.

===================================================================

M	source/blender/gpu/vulkan/vk_texture.cc

===================================================================

diff --git a/source/blender/gpu/vulkan/vk_texture.cc b/source/blender/gpu/vulkan/vk_texture.cc
index 4d0ee215454..d9cf15739c5 100644
--- a/source/blender/gpu/vulkan/vk_texture.cc
+++ b/source/blender/gpu/vulkan/vk_texture.cc
@@ -73,7 +73,7 @@ bool VKTexture::init_internal(void)
     info.usage = usage;
     info.flags = 0;
 
-    views_.resize(info.mipLevels * (info.arrayLayers + 1));
+    views_.resize(info.mipLevels * (info.arrayLayers + 1), VK_NULL_HANDLE);
 
     VmaAllocationCreateInfo alloc_info = {};
     alloc_info.requiredFlags = VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT;



More information about the Bf-blender-cvs mailing list