[Bf-blender-cvs] [501d2443d03] master: Cleanup: use const arguments for accessor functions

Campbell Barton noreply at git.blender.org
Wed Jun 30 08:44:09 CEST 2021


Commit: 501d2443d03cce18985fab3ffad5d23238748f3e
Author: Campbell Barton
Date:   Wed Jun 30 16:37:14 2021 +1000
Branches: master
https://developer.blender.org/rB501d2443d03cce18985fab3ffad5d23238748f3e

Cleanup: use const arguments for accessor functions

===================================================================

M	source/blender/blenkernel/BKE_armature.h
M	source/blender/blenkernel/BKE_collection.h
M	source/blender/blenkernel/BKE_fcurve.h
M	source/blender/blenkernel/BKE_gpencil_geom.h
M	source/blender/blenkernel/BKE_key.h
M	source/blender/blenkernel/BKE_layer.h
M	source/blender/blenkernel/BKE_pbvh.h
M	source/blender/blenkernel/BKE_shader_fx.h
M	source/blender/blenkernel/BKE_text.h
M	source/blender/blenkernel/BKE_undo_system.h
M	source/blender/blenkernel/intern/armature.c
M	source/blender/blenkernel/intern/collection.c
M	source/blender/blenkernel/intern/fcurve.c
M	source/blender/blenkernel/intern/gpencil_geom.c
M	source/blender/blenkernel/intern/key.c
M	source/blender/blenkernel/intern/layer.c
M	source/blender/blenkernel/intern/layer_utils.c
M	source/blender/blenkernel/intern/pbvh.c
M	source/blender/blenkernel/intern/shader_fx.c
M	source/blender/blenkernel/intern/softbody.c
M	source/blender/blenkernel/intern/text.c
M	source/blender/blenkernel/intern/undo_system.c
M	source/blender/blenlib/BLI_dynstr.h
M	source/blender/blenlib/BLI_edgehash.h
M	source/blender/blenlib/BLI_ghash.h
M	source/blender/blenlib/BLI_mempool.h
M	source/blender/blenlib/intern/BLI_dynstr.c
M	source/blender/blenlib/intern/BLI_ghash.c
M	source/blender/blenlib/intern/BLI_mempool.c
M	source/blender/blenlib/intern/edgehash.c
M	source/blender/blenloader/intern/versioning_cycles.c
M	source/blender/editors/animation/anim_filter.c
M	source/blender/editors/animation/keyframing.c
M	source/blender/editors/curve/editcurve_select.c
M	source/blender/editors/gizmo_library/gizmo_types/snap3d_gizmo.c
M	source/blender/editors/gpencil/editaction_gpencil.c
M	source/blender/editors/gpencil/gpencil_data.c
M	source/blender/editors/gpencil/gpencil_sculpt_paint.c
M	source/blender/editors/gpencil/gpencil_utils.c
M	source/blender/editors/include/ED_curve.h
M	source/blender/editors/include/ED_gizmo_library.h
M	source/blender/editors/include/ED_gpencil.h
M	source/blender/editors/include/ED_keyframing.h
M	source/blender/editors/include/ED_mask.h
M	source/blender/editors/include/ED_node.h
M	source/blender/editors/include/ED_object.h
M	source/blender/editors/interface/interface_widgets.c
M	source/blender/editors/mask/mask_editaction.c
M	source/blender/editors/object/object_edit.c
M	source/blender/editors/object/object_modes.c
M	source/blender/editors/object/object_vgroup.c
M	source/blender/editors/render/render_shading.c
M	source/blender/editors/space_node/node_edit.cc
M	source/blender/editors/transform/transform_constraints.c
M	source/blender/editors/transform/transform_constraints.h
M	source/blender/makesrna/RNA_access.h
M	source/blender/makesrna/intern/rna_access.c
M	source/blender/modifiers/intern/MOD_ui_common.c
M	source/blender/render/RE_bake.h
M	source/blender/render/intern/engine.c
M	source/blender/render/intern/render_result.c
M	source/blender/render/intern/render_result.h
M	source/blender/sequencer/SEQ_iterator.h
M	source/blender/sequencer/SEQ_utils.h
M	source/blender/sequencer/intern/iterator.c
M	source/blender/sequencer/intern/prefetch.c
M	source/blender/sequencer/intern/sequence_lookup.c
M	source/blender/sequencer/intern/utils.c
M	source/blender/windowmanager/WM_api.h
M	source/blender/windowmanager/intern/wm_jobs.c

===================================================================

diff --git a/source/blender/blenkernel/BKE_armature.h b/source/blender/blenkernel/BKE_armature.h
index 07b7aa2ec50..86aa18e5739 100644
--- a/source/blender/blenkernel/BKE_armature.h
+++ b/source/blender/blenkernel/BKE_armature.h
@@ -151,7 +151,7 @@ typedef struct PoseTree {
 
 struct bArmature *BKE_armature_add(struct Main *bmain, const char *name);
 struct bArmature *BKE_armature_from_object(struct Object *ob);
-int BKE_armature_bonelist_count(struct ListBase *lb);
+int BKE_armature_bonelist_count(const struct ListBase *lb);
 void BKE_armature_bonelist_free(struct ListBase *lb, const bool do_id_user);
 void BKE_armature_editbonelist_free(struct ListBase *lb, const bool do_id_user);
 
diff --git a/source/blender/blenkernel/BKE_collection.h b/source/blender/blenkernel/BKE_collection.h
index 7963d54126e..f47cdf32ca0 100644
--- a/source/blender/blenkernel/BKE_collection.h
+++ b/source/blender/blenkernel/BKE_collection.h
@@ -164,7 +164,8 @@ bool BKE_collection_move(struct Main *bmain,
 bool BKE_collection_cycle_find(struct Collection *new_ancestor, struct Collection *collection);
 bool BKE_collection_cycles_fix(struct Main *bmain, struct Collection *collection);
 
-bool BKE_collection_has_collection(struct Collection *parent, struct Collection *collection);
+bool BKE_collection_has_collection(const struct Collection *parent,
+                                   const struct Collection *collection);
 
 void BKE_collection_parent_relations_rebuild(struct Collection *collection);
 void BKE_main_collections_parent_relations_rebuild(struct Main *bmain);
diff --git a/source/blender/blenkernel/BKE_fcurve.h b/source/blender/blenkernel/BKE_fcurve.h
index ed2d9d4507f..f494c2e30cc 100644
--- a/source/blender/blenkernel/BKE_fcurve.h
+++ b/source/blender/blenkernel/BKE_fcurve.h
@@ -227,9 +227,9 @@ struct FCurve *BKE_fcurve_find_by_rna_context_ui(struct bContext *C,
 /* Binary search algorithm for finding where to 'insert' BezTriple with given frame number.
  * Returns the index to insert at (data already at that index will be offset if replace is 0)
  */
-int BKE_fcurve_bezt_binarysearch_index(struct BezTriple array[],
-                                       float frame,
-                                       int arraylen,
+int BKE_fcurve_bezt_binarysearch_index(const struct BezTriple array[],
+                                       const float frame,
+                                       const int arraylen,
                                        bool *r_replace);
 
 /* fcurve_cache.c */
diff --git a/source/blender/blenkernel/BKE_gpencil_geom.h b/source/blender/blenkernel/BKE_gpencil_geom.h
index 8fc3ce133a0..c1ccae7a437 100644
--- a/source/blender/blenkernel/BKE_gpencil_geom.h
+++ b/source/blender/blenkernel/BKE_gpencil_geom.h
@@ -90,7 +90,7 @@ typedef struct GPencilPointCoordinates {
   float pressure;
 } GPencilPointCoordinates;
 
-int BKE_gpencil_stroke_point_count(struct bGPdata *gpd);
+int BKE_gpencil_stroke_point_count(const struct bGPdata *gpd);
 void BKE_gpencil_point_coords_get(struct bGPdata *gpd, GPencilPointCoordinates *elem_data);
 void BKE_gpencil_point_coords_apply(struct bGPdata *gpd, const GPencilPointCoordinates *elem_data);
 void BKE_gpencil_point_coords_apply_with_mat4(struct bGPdata *gpd,
diff --git a/source/blender/blenkernel/BKE_key.h b/source/blender/blenkernel/BKE_key.h
index c969ce07d74..58b8d19abaa 100644
--- a/source/blender/blenkernel/BKE_key.h
+++ b/source/blender/blenkernel/BKE_key.h
@@ -76,7 +76,7 @@ void BKE_keyblock_update_from_lattice(struct Lattice *lt, struct KeyBlock *kb);
 void BKE_keyblock_convert_from_lattice(struct Lattice *lt, struct KeyBlock *kb);
 void BKE_keyblock_convert_to_lattice(struct KeyBlock *kb, struct Lattice *lt);
 
-int BKE_keyblock_curve_element_count(struct ListBase *nurb);
+int BKE_keyblock_curve_element_count(const struct ListBase *nurb);
 void BKE_keyblock_curve_data_transform(const struct ListBase *nurb,
                                        const float mat[4][4],
                                        const void *src,
diff --git a/source/blender/blenkernel/BKE_layer.h b/source/blender/blenkernel/BKE_layer.h
index 240d6cb18ec..404f344919c 100644
--- a/source/blender/blenkernel/BKE_layer.h
+++ b/source/blender/blenkernel/BKE_layer.h
@@ -92,7 +92,7 @@ bool BKE_layer_collection_activate(struct ViewLayer *view_layer, struct LayerCol
 struct LayerCollection *BKE_layer_collection_activate_parent(struct ViewLayer *view_layer,
                                                              struct LayerCollection *lc);
 
-int BKE_layer_collection_count(struct ViewLayer *view_layer);
+int BKE_layer_collection_count(const struct ViewLayer *view_layer);
 
 struct LayerCollection *BKE_layer_collection_from_index(struct ViewLayer *view_layer,
                                                         const int index);
@@ -107,8 +107,8 @@ void BKE_layer_collection_local_sync_all(const struct Main *bmain);
 void BKE_main_collection_sync_remap(const struct Main *bmain);
 
 struct LayerCollection *BKE_layer_collection_first_from_scene_collection(
-    struct ViewLayer *view_layer, const struct Collection *collection);
-bool BKE_view_layer_has_collection(struct ViewLayer *view_layer,
+    const struct ViewLayer *view_layer, const struct Collection *collection);
+bool BKE_view_layer_has_collection(const struct ViewLayer *view_layer,
                                    const struct Collection *collection);
 bool BKE_scene_has_object(struct Scene *scene, struct Object *ob);
 
@@ -367,7 +367,7 @@ void BKE_view_layer_visible_bases_iterator_end(BLI_Iterator *iter);
 struct ObjectsInViewLayerParams {
   uint no_dup_data : 1;
 
-  bool (*filter_fn)(struct Object *ob, void *user_data);
+  bool (*filter_fn)(const struct Object *ob, void *user_data);
   void *filter_userdata;
 };
 
@@ -388,7 +388,7 @@ struct ObjectsInModeParams {
   int object_mode;
   uint no_dup_data : 1;
 
-  bool (*filter_fn)(struct Object *ob, void *user_data);
+  bool (*filter_fn)(const struct Object *ob, void *user_data);
   void *filter_userdata;
 };
 
@@ -412,8 +412,8 @@ struct Object **BKE_view_layer_array_from_objects_in_mode_params(
   BKE_view_layer_array_from_bases_in_mode_params( \
       view_layer, v3d, r_len, &(const struct ObjectsInModeParams)__VA_ARGS__)
 
-bool BKE_view_layer_filter_edit_mesh_has_uvs(struct Object *ob, void *user_data);
-bool BKE_view_layer_filter_edit_mesh_has_edges(struct Object *ob, void *user_data);
+bool BKE_view_layer_filter_edit_mesh_has_uvs(const struct Object *ob, void *user_data);
+bool BKE_view_layer_filter_edit_mesh_has_edges(const struct Object *ob, void *user_data);
 
 /* Utility macros that wrap common args (add more as needed). */
 
diff --git a/source/blender/blenkernel/BKE_pbvh.h b/source/blender/blenkernel/BKE_pbvh.h
index 0fa44067b16..97e5698d6f9 100644
--- a/source/blender/blenkernel/BKE_pbvh.h
+++ b/source/blender/blenkernel/BKE_pbvh.h
@@ -474,7 +474,7 @@ bool BKE_pbvh_node_vert_update_check_any(PBVH *pbvh, PBVHNode *node);
 // void BKE_pbvh_node_BB_reset(PBVHNode *node);
 // void BKE_pbvh_node_BB_expand(PBVHNode *node, float co[3]);
 
-bool pbvh_has_mask(PBVH *pbvh);
+bool pbvh_has_mask(const PBVH *pbvh);
 void pbvh_show_mask_set(PBVH *pbvh, bool show_mask);
 
 bool pbvh_has_face_sets(PBVH *pbvh);
diff --git a/source/blender/blenkernel/BKE_shader_fx.h b/source/blender/blenkernel/BKE_shader_fx.h
index 7e3783a3ee9..8d1fe709355 100644
--- a/source/blender/blenkernel/BKE_shader_fx.h
+++ b/source/blender/blenkernel/BKE_shader_fx.h
@@ -172,7 +172,7 @@ void BKE_shaderfx_copydata_ex(struct ShaderFxData *fx,
 void BKE_shaderfx_copy(struct ListBase *dst, const struct ListBase *src);
 void BKE_shaderfx_foreach_ID_link(struct Object *ob, ShaderFxIDWalkFunc walk, void *userData);
 
-bool BKE_shaderfx_has_gpencil(struct Object *ob);
+bool BKE_shaderfx_has_gpencil(const struct Object *ob);
 
 void BKE_shaderfx_blend_write(struct BlendWriter *writer, struct ListBase *fxbase);
 void BKE_shaderfx_blend_read_data(struct BlendDataReader *reader, struct ListBase *lb);
diff --git a/source/blender/blenkernel/BKE_text.h b/source/blender/blenkernel/BKE_text.h
index 26351ee65c2..c7120c60020 100644
--- a/source/blender/blenkernel/BKE_text.h
+++ b/source/blender/blenkernel/BKE_text.h
@@ -48,7 +48,7 @@ char *txt_to_buf(struct Text *text, int *r_buf_strlen);
 void txt_clean_text(struct Text *text);
 void txt_order_cursors(struct Text *text, const bool reverse);
 int txt_find_string(struct Text *text, const char *findstr, int wrap, int match_case);
-bool txt_has_sel(struct Text *text);
+bool txt_has_sel(const struct Text *text);
 int txt_get_span(struct TextLine *from, struct TextLine *to);
 void txt_move_up(struct Text *text, const bool sel);
 void txt_move_down(struct Text *text, const bool sel);
@@ -85,8 +85,8 @@ bool txt_uncomment(struct Text *text);
 void txt_move_lines(struct Text *text, const int direction);
 void txt_duplicate_line(struct Text *text);
 int txt_setcurr_tab_spaces(struct Text *text, int space);
-bool txt_cursor_is_line_start(struct Text *text);
-bool txt_cursor_is_line_end(struct Text *text);
+bool txt_cursor_is_line_start(const struct Text *text);
+bool txt_cursor_is_line_end(const struct Text *text);
 
 int txt_calc_tab_left(struct TextLine *tl, int ch);
 int txt_calc_tab_right(struct TextLine *tl, int ch);
diff --git a/source/blender/blenkernel/BKE_undo_system.h b/source/blender/blenkernel/BKE_undo_system.h
index 620496864f5..efac5d9097f 100644
--- a/source/blender/blenkernel/BKE_undo_system.h
+++ b/source/blender/blenkernel/BKE_undo_system.h
@@ -178,7 +178,7 @@ UndoStack *BKE_undosys_stack_create(void);
 void BKE_undosys_stack_destroy(UndoStack *ustack);
 void BKE_undosys_stack_clear(UndoStack *ustack);
 void BKE_undosys_stack_clear_active(UndoStack *ustack);
-bool BKE_undosys_stack_has_undo(UndoStack *ustack, const char *name);
+bool BKE_undosys_stack_has_undo(const UndoStack *ustack, const char *name);
 void BKE_undosys_stack_init_from_main(UndoStack *ustack, struct Main *bmain);
 void BKE_undosys_stack_init_from_context(UndoStack *ustack, struct bContext *C);
 UndoStep *BKE_undosys_stack_active_with_type(UndoStack *ustack, const UndoType *ut);
diff --git a/source/blender/blenkernel/intern/armature.c 

@@ Diff output truncated at 10240 characters. @@



More information about the Bf-blender-cvs mailing list