[Bf-blender-cvs] [25b341a4ae4] tmp-vulkan: Vulkan: Fix double free of shader interface.

Jeroen Bakker noreply at git.blender.org
Mon Jun 28 15:57:50 CEST 2021


Commit: 25b341a4ae45bf41f4593b860519aeb413ee0a83
Author: Jeroen Bakker
Date:   Mon Jun 28 15:56:46 2021 +0200
Branches: tmp-vulkan
https://developer.blender.org/rB25b341a4ae45bf41f4593b860519aeb413ee0a83

Vulkan: Fix double free of shader interface.

interface is allocated by a subclass but freed by the parent class.
Might consider a uniqueptr here.

===================================================================

M	source/blender/gpu/vulkan/vk_shader.cc

===================================================================

diff --git a/source/blender/gpu/vulkan/vk_shader.cc b/source/blender/gpu/vulkan/vk_shader.cc
index f942feabe6c..10eef786321 100644
--- a/source/blender/gpu/vulkan/vk_shader.cc
+++ b/source/blender/gpu/vulkan/vk_shader.cc
@@ -111,7 +111,6 @@ VKShader::~VKShader()
     compute_shader_ = VK_NULL_HANDLE;
   }
 
-  delete interface;
   context_ = nullptr;
 };



More information about the Bf-blender-cvs mailing list