[Bf-blender-cvs] [0f427f4eb1c] master: Cleanup: suppress clang-tidy warnings

Campbell Barton noreply at git.blender.org
Wed Jun 23 05:57:56 CEST 2021


Commit: 0f427f4eb1c43b2e2336991de27f8985a4e0e824
Author: Campbell Barton
Date:   Wed Jun 23 11:44:39 2021 +1000
Branches: master
https://developer.blender.org/rB0f427f4eb1c43b2e2336991de27f8985a4e0e824

Cleanup: suppress clang-tidy warnings

===================================================================

M	source/blender/blenlib/tests/BLI_string_test.cc

===================================================================

diff --git a/source/blender/blenlib/tests/BLI_string_test.cc b/source/blender/blenlib/tests/BLI_string_test.cc
index 88cecaa5fee..281b7103b75 100644
--- a/source/blender/blenlib/tests/BLI_string_test.cc
+++ b/source/blender/blenlib/tests/BLI_string_test.cc
@@ -832,6 +832,9 @@ class StringEscape : public testing::Test {
 
 TEST_F(StringEscape, Simple)
 {
+  /* NOTE: clang-tidy `modernize-raw-string-literal` is disabled as it causes errors with MSVC.
+   * TODO: investigate resolving with `/Zc:preprocessor` flag. */
+
   const CompareWordsArray equal{
       {"", ""},
       {"/", "/"},
@@ -845,11 +848,16 @@ TEST_F(StringEscape, Simple)
       {"\\A", "\\\\A"},
       {"A\\B", "A\\\\B"},
       {"?", "?"},
+      /* NOLINTNEXTLINE: modernize-raw-string-literal. */
       {"\"\\", "\\\"\\\\"},
+      /* NOLINTNEXTLINE: modernize-raw-string-literal. */
       {"\\\"", "\\\\\\\""},
+      /* NOLINTNEXTLINE: modernize-raw-string-literal. */
       {"\"\\\"", "\\\"\\\\\\\""},
 
+      /* NOLINTNEXTLINE: modernize-raw-string-literal. */
       {"\"\"\"", "\\\"\\\"\\\""},
+      /* NOLINTNEXTLINE: modernize-raw-string-literal. */
       {"\\\\\\", "\\\\\\\\\\\\"},
   };
 
@@ -868,8 +876,11 @@ TEST_F(StringEscape, Control)
       {"\f", "\\f"},
       {"A\n", "A\\n"},
       {"\nA", "\\nA"},
+      /* NOLINTNEXTLINE: modernize-raw-string-literal. */
       {"\n\r\t\a\b\f", "\\n\\r\\t\\a\\b\\f"},
+      /* NOLINTNEXTLINE: modernize-raw-string-literal. */
       {"\n_\r_\t_\a_\b_\f", "\\n_\\r_\\t_\\a_\\b_\\f"},
+      /* NOLINTNEXTLINE: modernize-raw-string-literal. */
       {"\n\\\r\\\t\\\a\\\b\\\f", "\\n\\\\\\r\\\\\\t\\\\\\a\\\\\\b\\\\\\f"},
   };



More information about the Bf-blender-cvs mailing list