[Bf-blender-cvs] [94c4a9995e4] master: Fix T89233: Incorrect attribute remove warning for curves

[Hans Goudey]

Commit: 94c4a9995e43a5921adb33da80591e0c4cf3fe9b
Author: Hans Goudey
Date:   Thu Jun 17 17:22:09 2021 -0500
Branches: master
https://developer.blender.org/rB94c4a9995e43a5921adb33da80591e0c4cf3fe9b

Fix T89233: Incorrect attribute remove warning for curves

The curve attribute delete function didn't return whether it was
successful or not.

===================================================================

M	source/blender/blenkernel/intern/geometry_component_curve.cc

===================================================================

diff --git a/source/blender/blenkernel/intern/geometry_component_curve.cc b/source/blender/blenkernel/intern/geometry_component_curve.cc
index bc85305fea8..b5c49dbb8b2 100644
--- a/source/blender/blenkernel/intern/geometry_component_curve.cc
+++ b/source/blender/blenkernel/intern/geometry_component_curve.cc
@@ -1011,9 +1011,10 @@ class DynamicPointAttributeProvider final : public DynamicAttributesProvider {
       return false;
     }
 
+    /* Reuse the boolean for all splines; we expect all splines to have the same attributes. */
     bool layer_freed = false;
     for (SplinePtr &spline : curve->splines()) {
-      spline->attributes.remove(attribute_name);
+      layer_freed = spline->attributes.remove(attribute_name);
     }
     return layer_freed;
   }