[Bf-blender-cvs] [6d644c587be] temp-lineart-contained: LineArt: Use NOTE instead of FIXME.

YimingWu noreply at git.blender.org
Wed Jun 2 13:56:55 CEST 2021


Commit: 6d644c587bec90cea12aa84862487319bdd00459
Author: YimingWu
Date:   Wed Jun 2 19:56:26 2021 +0800
Branches: temp-lineart-contained
https://developer.blender.org/rB6d644c587bec90cea12aa84862487319bdd00459

LineArt: Use NOTE instead of FIXME.

===================================================================

M	source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c

===================================================================

diff --git a/source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c b/source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c
index e9810294820..509a5efdc70 100644
--- a/source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c
+++ b/source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c
@@ -2336,9 +2336,9 @@ static bool lineart_triangle_edge_image_space_occlusion(SpinLock *UNUSED(spl),
   dot_r = dot_v3v3_db(Rv, tri->gn);
   dot_f = dot_v3v3_db(Cv, tri->gn);
 
-  /* FIXME: When we don't use `dot_f==0` here, it's theoretically possibile that _some_ faces in
-   * perspective mode would get erroneously caught in this condition where they really are legit
-   * faces that would produce occlusion, but haven't encountered those yet in my test files.
+  /* NOTE(Yiming): When we don't use `dot_f==0` here, it's theoretically possibile that _some_
+   * faces in perspective mode would get erroneously caught in this condition where they really are
+   * legit faces that would produce occlusion, but haven't encountered those yet in my test files.
    */
   if (fabs(dot_f) < FLT_EPSILON) {
     return false;



More information about the Bf-blender-cvs mailing list