[Bf-blender-cvs] [27910ccce6a] master: Cleanup: clang-tidy

[Jacques Lucke]

Commit: 27910ccce6a0a6a79b09144631309331cb557a25
Author: Jacques Lucke
Date:   Tue Jun 1 12:00:16 2021 +0200
Branches: master
https://developer.blender.org/rB27910ccce6a0a6a79b09144631309331cb557a25

Cleanup: clang-tidy

* `readability-redundant-member-init`
* `readability-inconsistent-declaration-parameter-name`
* Remove constructor that can be defaulted.

===================================================================

M	source/blender/compositor/intern/COM_BufferOperation.cc
M	source/blender/compositor/intern/COM_FullFrameExecutionModel.cc
M	source/blender/compositor/intern/COM_MultiThreadedOperation.h
M	source/blender/compositor/intern/COM_SharedOperationBuffers.cc
M	source/blender/compositor/intern/COM_SharedOperationBuffers.h

===================================================================

diff --git a/source/blender/compositor/intern/COM_BufferOperation.cc b/source/blender/compositor/intern/COM_BufferOperation.cc
index c1e64142443..8464d01801f 100644
--- a/source/blender/compositor/intern/COM_BufferOperation.cc
+++ b/source/blender/compositor/intern/COM_BufferOperation.cc
@@ -20,7 +20,7 @@
 
 namespace blender::compositor {
 
-BufferOperation::BufferOperation(MemoryBuffer *buffer, DataType data_type) : NodeOperation()
+BufferOperation::BufferOperation(MemoryBuffer *buffer, DataType data_type)
 {
   buffer_ = buffer;
   /* TODO: Implement a MemoryBuffer get_size() method returning a Size2d type. Shorten following
diff --git a/source/blender/compositor/intern/COM_FullFrameExecutionModel.cc b/source/blender/compositor/intern/COM_FullFrameExecutionModel.cc
index 1099aadd89d..396aa2fcf6f 100644
--- a/source/blender/compositor/intern/COM_FullFrameExecutionModel.cc
+++ b/source/blender/compositor/intern/COM_FullFrameExecutionModel.cc
@@ -36,7 +36,6 @@ FullFrameExecutionModel::FullFrameExecutionModel(CompositorContext &context,
     : ExecutionModel(context, operations),
       active_buffers_(shared_buffers),
       num_operations_finished_(0),
-      priorities_(),
       work_mutex_(),
       work_finished_cond_()
 {
diff --git a/source/blender/compositor/intern/COM_MultiThreadedOperation.h b/source/blender/compositor/intern/COM_MultiThreadedOperation.h
index e86b1d303f9..97c5fba4ead 100644
--- a/source/blender/compositor/intern/COM_MultiThreadedOperation.h
+++ b/source/blender/compositor/intern/COM_MultiThreadedOperation.h
@@ -65,7 +65,7 @@ class MultiThreadedOperation : public NodeOperation {
 
  private:
   void update_memory_buffer(MemoryBuffer *output,
-                            const rcti &output_rect,
+                            const rcti &output_area,
                             blender::Span<MemoryBuffer *> inputs,
                             ExecutionSystem &exec_system) override;
 };
diff --git a/source/blender/compositor/intern/COM_SharedOperationBuffers.cc b/source/blender/compositor/intern/COM_SharedOperationBuffers.cc
index 021e948a727..4ce674a1c25 100644
--- a/source/blender/compositor/intern/COM_SharedOperationBuffers.cc
+++ b/source/blender/compositor/intern/COM_SharedOperationBuffers.cc
@@ -22,11 +22,8 @@
 
 namespace blender::compositor {
 
-SharedOperationBuffers::SharedOperationBuffers() : buffers_()
-{
-}
 SharedOperationBuffers::BufferData::BufferData()
-    : buffer(nullptr), render_areas(), registered_reads(0), received_reads(0)
+    : buffer(nullptr), registered_reads(0), received_reads(0)
 {
 }
 
diff --git a/source/blender/compositor/intern/COM_SharedOperationBuffers.h b/source/blender/compositor/intern/COM_SharedOperationBuffers.h
index 9e90a06a0d3..480a799d89f 100644
--- a/source/blender/compositor/intern/COM_SharedOperationBuffers.h
+++ b/source/blender/compositor/intern/COM_SharedOperationBuffers.h
@@ -46,7 +46,6 @@ class SharedOperationBuffers {
   blender::Map<NodeOperation *, BufferData> buffers_;
 
  public:
-  SharedOperationBuffers();
   bool is_area_registered(NodeOperation *op, const rcti &area_to_render);
   void register_area(NodeOperation *op, const rcti &area_to_render);