[Bf-blender-cvs] [4886ed28637] master: Fix T86768, bevel doesn't loop slide sometimes.

[Howard Trickey]

Commit: 4886ed28637cbda056980467934d9d7c4190b6e2
Author: Howard Trickey
Date:   Sun Jul 25 15:14:37 2021 -0400
Branches: master
https://developer.blender.org/rB4886ed28637cbda056980467934d9d7c4190b6e2

Fix T86768, bevel doesn't loop slide sometimes.

Six years ago, Bug T44961 about unwanted spikes had me not do a loop
slide if the angle was too extreme, to avoid unwanted spikes.
The current bug showed that that angle was much too big, and limited
desired behavior in many cases. Changing the angle from 0.25 radians
to 0.0001 radians (about 0.006 degrees) still fixes the original bug
and seems very unlikely to be limiting desired behavior now.

===================================================================

M	source/blender/bmesh/tools/bmesh_bevel.c

===================================================================

diff --git a/source/blender/bmesh/tools/bmesh_bevel.c b/source/blender/bmesh/tools/bmesh_bevel.c
index 1e8ef9737d3..fd18153ec2c 100644
--- a/source/blender/bmesh/tools/bmesh_bevel.c
+++ b/source/blender/bmesh/tools/bmesh_bevel.c
@@ -1495,8 +1495,9 @@ static void offset_meet(BevelParams *bp,
   }
 }
 
-/* Chosen so 1/sin(BEVEL_GOOD_ANGLE) is about 4, giving that expansion factor to bevel width. */
-#define BEVEL_GOOD_ANGLE 0.25f
+/* This was changed from 0.25f to fix bug T86768. Original bug T44961 remainx fixed with this
+ * value. */
+#define BEVEL_GOOD_ANGLE 0.0001f
 
 /**
  * Calculate the meeting point between e1 and e2 (one of which should have zero offsets),