[Bf-blender-cvs] [66dfef10a79] master: Fix error setting sharp edges in recent normal calculation changes

Campbell Barton noreply at git.blender.org
Fri Jul 23 07:03:42 CEST 2021


Commit: 66dfef10a79bc8ce7498e5d5d0aeef8752a0fdc8
Author: Campbell Barton
Date:   Fri Jul 23 15:02:04 2021 +1000
Branches: master
https://developer.blender.org/rB66dfef10a79bc8ce7498e5d5d0aeef8752a0fdc8

Fix error setting sharp edges in recent normal calculation changes

bm_mesh_edges_sharp_tag was called with setting sharp edges enabled.
Error in 39b2a7bb7e815e051348bf5c5ec777d091324164.

===================================================================

M	source/blender/bmesh/intern/bmesh_mesh_normals.c

===================================================================

diff --git a/source/blender/bmesh/intern/bmesh_mesh_normals.c b/source/blender/bmesh/intern/bmesh_mesh_normals.c
index 210e92e7b6d..c94882dde65 100644
--- a/source/blender/bmesh/intern/bmesh_mesh_normals.c
+++ b/source/blender/bmesh/intern/bmesh_mesh_normals.c
@@ -1106,7 +1106,7 @@ static void bm_mesh_loops_calc_normals__single_threaded(BMesh *bm,
   }
 
   if (split_angle_cos != -1.0f) {
-    bm_mesh_edges_sharp_tag(bm, fnos, has_clnors ? (float)M_PI : split_angle, true);
+    bm_mesh_edges_sharp_tag(bm, fnos, has_clnors ? (float)M_PI : split_angle, false);
   }
 
   /* Clear all loops' tags (means none are to be skipped for now). */



More information about the Bf-blender-cvs mailing list