[Bf-blender-cvs] [83b6fcc70c2] master: Fix: Bezier segment node adds handles incorrectly

Johnny Matthews noreply at git.blender.org
Tue Jul 20 15:58:35 CEST 2021


Commit: 83b6fcc70c2b083f95a50a203592d3d5e9a17d42
Author: Johnny Matthews
Date:   Tue Jul 20 09:58:24 2021 -0400
Branches: master
https://developer.blender.org/rB83b6fcc70c2b083f95a50a203592d3d5e9a17d42

Fix: Bezier segment node adds handles incorrectly

This caused the "cyclic" attribute to appear dysfunctional.

===================================================================

M	source/blender/nodes/geometry/nodes/node_geo_curve_primitive_bezier_segment.cc

===================================================================

diff --git a/source/blender/nodes/geometry/nodes/node_geo_curve_primitive_bezier_segment.cc b/source/blender/nodes/geometry/nodes/node_geo_curve_primitive_bezier_segment.cc
index e167219ea6b..78b5b109419 100644
--- a/source/blender/nodes/geometry/nodes/node_geo_curve_primitive_bezier_segment.cc
+++ b/source/blender/nodes/geometry/nodes/node_geo_curve_primitive_bezier_segment.cc
@@ -74,7 +74,7 @@ static std::unique_ptr<CurveEval> create_bezier_segment_curve(
   if (mode == GEO_NODE_CURVE_PRIMITIVE_BEZIER_SEGMENT_POSITION) {
     spline->add_point(start,
                       BezierSpline::HandleType::Align,
-                      start - (start_handle_right - start) * -1.0f,
+                      2.0f * start - start_handle_right,
                       BezierSpline::HandleType::Align,
                       start_handle_right,
                       1.0f,
@@ -83,7 +83,7 @@ static std::unique_ptr<CurveEval> create_bezier_segment_curve(
                       BezierSpline::HandleType::Align,
                       end_handle_left,
                       BezierSpline::HandleType::Align,
-                      end - (end_handle_left - end) * -1.0f,
+                      2.0f * end - end_handle_left,
                       1.0f,
                       0.0f);
   }



More information about the Bf-blender-cvs mailing list