[Bf-blender-cvs] [7ac66633ae0] asset-greasepencil: GPencil: Fix memory leak

Antonio Vazquez noreply at git.blender.org
Fri Jul 9 20:23:07 CEST 2021


Commit: 7ac66633ae020218db1d03e70ea07f45ca7af61a
Author: Antonio Vazquez
Date:   Fri Jul 9 20:23:03 2021 +0200
Branches: asset-greasepencil
https://developer.blender.org/rB7ac66633ae020218db1d03e70ea07f45ca7af61a

GPencil: Fix memory leak

The id_copy free must be reviewed.

===================================================================

M	source/blender/editors/render/render_preview.c

===================================================================

diff --git a/source/blender/editors/render/render_preview.c b/source/blender/editors/render/render_preview.c
index a4eae479de2..6981ce39e30 100644
--- a/source/blender/editors/render/render_preview.c
+++ b/source/blender/editors/render/render_preview.c
@@ -885,7 +885,7 @@ static Scene *gpencil_preview_scene_create(const struct ObjectPreviewData *previ
                                             OB_GPENCIL,
                                             "preview_object",
                                             preview_data->datablock,
-                                            false);
+                                            true);
   BLI_assert(ob_temp != NULL);
   /* Copy the materials to get full color previews. */
   const short *materials_len_p = BKE_id_material_len_p(preview_data->datablock);
@@ -936,9 +936,6 @@ static void gpencil_preview_render(IconPreview *preview, IconPreviewSize *previe
   Depsgraph *depsgraph;
   Scene *scene = gpencil_preview_scene_create(&preview_data, &depsgraph);
 
-  /* Ownership is now ours. */
-  preview->id_copy = NULL;
-
   U.pixelsize = 2.0f;
 
   View3DShading shading;



More information about the Bf-blender-cvs mailing list