[Bf-blender-cvs] [c3548b9e42d] temp-socket-inspection: Geometry Nodes: Initial socket inspection.

[Jacques Lucke]

Commit: c3548b9e42d34ee8768195b72249977a06e39f5b
Author: Jacques Lucke
Date:   Wed Jul 7 16:07:07 2021 +0200
Branches: temp-socket-inspection
https://developer.blender.org/rBc3548b9e42d34ee8768195b72249977a06e39f5b

Geometry Nodes: Initial socket inspection.

Differential Revision: https://developer.blender.org/D11842

===================================================================

M	source/blender/editors/space_node/node_draw.cc

===================================================================

diff --git a/source/blender/editors/space_node/node_draw.cc b/source/blender/editors/space_node/node_draw.cc
index e8ecb9a19c4..6da2fa3351b 100644
--- a/source/blender/editors/space_node/node_draw.cc
+++ b/source/blender/editors/space_node/node_draw.cc
@@ -944,9 +944,16 @@ static void node_socket_draw_nested(const bContext *C,
                    size_id,
                    outline_col_id);
 
+  if (ntree->type != NTREE_GEOMETRY) {
+    /* Only geometry nodes has socket value tooltips currently. */
+    return;
+  }
+
   bNode *node = (bNode *)node_ptr->data;
   uiBlock *block = node->block;
 
+  /* Ideally sockets themselves should be buttons, but they aren't currently. So add an invisible
+   * button on top of them for the tooltip. */
   eUIEmbossType old_emboss = (eUIEmbossType)UI_block_emboss_get(block);
   UI_block_emboss_set(block, UI_EMBOSS_NONE);
   uiBut *but = uiDefIconBut(block,
@@ -982,6 +989,7 @@ static void node_socket_draw_nested(const bContext *C,
       },
       data,
       MEM_freeN);
+  /* Disable the button so that clicks on it are ignored the the link operator still works. */
   UI_but_flag_enable(but, UI_BUT_DISABLED);
   UI_block_emboss_set(block, old_emboss);
 }