[Bf-blender-cvs] [afe7387be81] master: BMesh: remove redundant copy-on-write tagging

Campbell Barton noreply at git.blender.org
Mon Jul 5 10:32:42 CEST 2021


Commit: afe7387be81ef04dc566a182ccadb2b1e739f809
Author: Campbell Barton
Date:   Mon Jul 5 18:27:38 2021 +1000
Branches: master
https://developer.blender.org/rBafe7387be81ef04dc566a182ccadb2b1e739f809

BMesh: remove redundant copy-on-write tagging

The evaluated meshes no longer store a copy of the edit-mesh
so tagging when a BMesh operator fails can be removed.

===================================================================

M	source/blender/editors/mesh/editmesh_utils.c

===================================================================

diff --git a/source/blender/editors/mesh/editmesh_utils.c b/source/blender/editors/mesh/editmesh_utils.c
index aa5cdafb05f..b384845513a 100644
--- a/source/blender/editors/mesh/editmesh_utils.c
+++ b/source/blender/editors/mesh/editmesh_utils.c
@@ -198,23 +198,6 @@ bool EDBM_op_finish(BMEditMesh *em, BMOperator *bmop, wmOperator *op, const bool
 
     edbm_op_emcopy_restore_and_clear(em, bmop);
 
-    /**
-     * NOTE: we could pass in the mesh, however this is an exceptional case, allow a slow lookup.
-     *
-     * This is needed because the COW mesh makes a full copy of the #BMEditMesh
-     * instead of sharing the pointer, tagging since this has been freed above,
-     * the #BMEditMesh.emcopy needs to be flushed to the COW edit-mesh, see T55457.
-     */
-    {
-      Main *bmain = G_MAIN;
-      for (Mesh *mesh = bmain->meshes.first; mesh; mesh = mesh->id.next) {
-        if (mesh->edit_mesh == em) {
-          DEG_id_tag_update(&mesh->id, ID_RECALC_COPY_ON_WRITE);
-          break;
-        }
-      }
-    }
-
     /* when copying, tessellation isn't to for faster copying,
      * but means we need to re-tessellate here */
     if (em->looptris == NULL) {



More information about the Bf-blender-cvs mailing list