[Bf-blender-cvs] [10ce2a1016a] master: NLA: Redundant NlaEvalChannel Valid Mask Write

Wayde Moss noreply at git.blender.org
Fri Jan 15 01:06:15 CET 2021


Commit: 10ce2a1016ae8fd23d12e81480f2365a3b99aad3
Author: Wayde Moss
Date:   Thu Jan 14 19:04:40 2021 -0500
Branches: master
https://developer.blender.org/rB10ce2a1016ae8fd23d12e81480f2365a3b99aad3

NLA: Redundant NlaEvalChannel Valid Mask Write

The field will already be properly written to in (anim_sys.c)
nla_eval_domain_action(). It's easier to understand the property's
usage after removing the redundancy.

No functional changes.

Reviewed by: ChrisLend, sybren

Differential Revision: http://developer.blender.org/D9689

===================================================================

M	source/blender/blenkernel/intern/anim_sys.c

===================================================================

diff --git a/source/blender/blenkernel/intern/anim_sys.c b/source/blender/blenkernel/intern/anim_sys.c
index 9fb3e8ea1f1..841bd88723c 100644
--- a/source/blender/blenkernel/intern/anim_sys.c
+++ b/source/blender/blenkernel/intern/anim_sys.c
@@ -1702,14 +1702,6 @@ static bool nlaeval_blend_value(NlaBlendData *blend,
     return false;
   }
 
-  if (nec->mix_mode == NEC_MIX_QUATERNION) {
-    /* For quaternion properties, always output all sub-channels. */
-    BLI_bitmap_set_all(nec->valid.ptr, true, 4);
-  }
-  else {
-    BLI_BITMAP_ENABLE(nec->valid.ptr, array_index);
-  }
-
   NlaEvalChannelSnapshot *nec_snapshot = nlaeval_snapshot_ensure_channel(blend->snapshot, nec);
   float *p_value = &nec_snapshot->values[array_index];



More information about the Bf-blender-cvs mailing list