[Bf-blender-cvs] [10423d462a4] blender-v2.92-release: Geometry Nodes: output color from Attribute Color Ramp node

Jacques Lucke noreply at git.blender.org
Thu Jan 14 12:44:45 CET 2021


Commit: 10423d462a4b4219c4f86d095258cb7287ee1560
Author: Jacques Lucke
Date:   Thu Jan 14 12:44:37 2021 +0100
Branches: blender-v2.92-release
https://developer.blender.org/rB10423d462a4b4219c4f86d095258cb7287ee1560

Geometry Nodes: output color from Attribute Color Ramp node

The other output types did not work currently anyway.
There is not a significant benefit in somehow deducing the output
attribute type from the existing attribute types.

===================================================================

M	source/blender/nodes/geometry/nodes/node_geo_attribute_color_ramp.cc

===================================================================

diff --git a/source/blender/nodes/geometry/nodes/node_geo_attribute_color_ramp.cc b/source/blender/nodes/geometry/nodes/node_geo_attribute_color_ramp.cc
index 5d126328988..2aca9ed581c 100644
--- a/source/blender/nodes/geometry/nodes/node_geo_attribute_color_ramp.cc
+++ b/source/blender/nodes/geometry/nodes/node_geo_attribute_color_ramp.cc
@@ -37,9 +37,10 @@ static void execute_on_component(const GeoNodeExecParams &params, GeometryCompon
   const bNode &bnode = params.node();
   NodeAttributeColorRamp *node_storage = (NodeAttributeColorRamp *)bnode.storage;
 
-  /* Use the type of the input attribute, but create a color attribute if it doesn't exist yet. */
-  const CustomDataType result_type = params.get_input_attribute_data_type(
-      "Attribute", component, CD_PROP_COLOR);
+  /* Always output a color attribute for now. We might want to allow users to customize.
+   * Using the type of an existing attribute could work, but does not have a real benefit
+   * currently. */
+  const CustomDataType result_type = CD_PROP_COLOR;
 
   const std::string result_name = params.get_input<std::string>("Result");
   /* Once we support more domains at the user level, we have to decide how the result domain is



More information about the Bf-blender-cvs mailing list