[Bf-blender-cvs] [3191b76eb53] master: GPencil: Noise Modifier - Move noise seed value outside of randomize subpanel

Cody Winchester noreply at git.blender.org
Thu Jan 14 11:10:43 CET 2021


Commit: 3191b76eb5343bd8c745f21566f9fd3fb012242b
Author: Cody Winchester
Date:   Thu Jan 14 11:09:32 2021 +0100
Branches: master
https://developer.blender.org/rB3191b76eb5343bd8c745f21566f9fd3fb012242b

GPencil: Noise Modifier - Move noise seed value outside of randomize subpanel

Currently the grease pencil noise modifier seed value is under the randomize subpanel.

Moved the seed value outside of this panel because it doesn't only change the noise when using the randomize option. Moving the seed value prevents it from being hidden/greyed out so the user can manually keyframe it to control the noise animation.

Reviewed By: #grease_pencil, antoniov

Differential Revision: https://developer.blender.org/D10020

===================================================================

M	source/blender/gpencil_modifiers/intern/MOD_gpencilnoise.c
M	source/blender/makesrna/intern/rna_gpencil_modifier.c

===================================================================

diff --git a/source/blender/gpencil_modifiers/intern/MOD_gpencilnoise.c b/source/blender/gpencil_modifiers/intern/MOD_gpencilnoise.c
index e2f4d34ff40..a65f1bf6d26 100644
--- a/source/blender/gpencil_modifiers/intern/MOD_gpencilnoise.c
+++ b/source/blender/gpencil_modifiers/intern/MOD_gpencilnoise.c
@@ -292,6 +292,7 @@ static void panel_draw(const bContext *UNUSED(C), Panel *panel)
   uiItemR(col, ptr, "factor_thickness", 0, IFACE_("Thickness"), ICON_NONE);
   uiItemR(col, ptr, "factor_uvs", 0, IFACE_("UV"), ICON_NONE);
   uiItemR(col, ptr, "noise_scale", 0, NULL, ICON_NONE);
+  uiItemR(col, ptr, "seed", 0, NULL, ICON_NONE);
 
   gpencil_modifier_panel_end(layout, ptr);
 }
@@ -316,7 +317,6 @@ static void random_panel_draw(const bContext *UNUSED(C), Panel *panel)
   uiLayoutSetActive(layout, RNA_boolean_get(ptr, "random"));
 
   uiItemR(layout, ptr, "step", 0, NULL, ICON_NONE);
-  uiItemR(layout, ptr, "seed", 0, NULL, ICON_NONE);
 }
 
 static void mask_panel_draw(const bContext *UNUSED(C), Panel *panel)
diff --git a/source/blender/makesrna/intern/rna_gpencil_modifier.c b/source/blender/makesrna/intern/rna_gpencil_modifier.c
index 89eb989a442..fb505d9a1fa 100644
--- a/source/blender/makesrna/intern/rna_gpencil_modifier.c
+++ b/source/blender/makesrna/intern/rna_gpencil_modifier.c
@@ -489,7 +489,7 @@ static void rna_def_modifier_gpencilnoise(BlenderRNA *brna)
   RNA_def_property_update(prop, 0, "rna_GpencilModifier_update");
 
   prop = RNA_def_property(srna, "seed", PROP_INT, PROP_UNSIGNED);
-  RNA_def_property_ui_text(prop, "Seed", "Random seed");
+  RNA_def_property_ui_text(prop, "Noise Seed", "Random seed");
   RNA_def_property_update(prop, 0, "rna_GpencilModifier_update");
 
   prop = RNA_def_property(srna, "noise_scale", PROP_FLOAT, PROP_FACTOR);



More information about the Bf-blender-cvs mailing list