[Bf-blender-cvs] [1698678231d] master: GPU: Mark AMD Polaris 20.11+ drivers with limited support.

[Jeroen Bakker]

Commit: 1698678231d20b57ed463d89270913599548ffcb
Author: Jeroen Bakker
Date:   Fri Jan 8 11:43:32 2021 +0100
Branches: master
https://developer.blender.org/rB1698678231d20b57ed463d89270913599548ffcb

GPU: Mark AMD Polaris 20.11+ drivers with limited support.

The issue does not render wireframes correctly.

===================================================================

M	source/blender/gpu/opengl/gl_backend.cc

===================================================================

diff --git a/source/blender/gpu/opengl/gl_backend.cc b/source/blender/gpu/opengl/gl_backend.cc
index 140425b349a..5c43a8990d7 100644
--- a/source/blender/gpu/opengl/gl_backend.cc
+++ b/source/blender/gpu/opengl/gl_backend.cc
@@ -34,6 +34,28 @@
 
 namespace blender::gpu {
 
+/* See T82856: AMD drivers since 20.11 running on a polaris architecture doesn't support the
+ * `GL_INT_2_10_10_10_REV` data type correctly. This data type is used to pack normals and flags.
+ * The work around uses `GPU_RGBA16I` but that is only possible for loop normals.
+ *
+ * Vertex and Face normals would still render resulting in undefined behavior during selection and
+ * rendering. */
+static bool is_faulty_T82856_platform(const char *version, const char *renderer)
+{
+  /* On Linux the driver does not report its version. Test the OpenGL version in stead. */
+  if (strstr(version, "4.5.14756") || strstr(version, "4.5.14757")) {
+    if (strstr(renderer, " RX 460 ") || strstr(renderer, " RX 470 ") ||
+        strstr(renderer, " RX 480 ") || strstr(renderer, " RX 490 ") ||
+        strstr(renderer, " RX 560 ") || strstr(renderer, " RX 560X ") ||
+        strstr(renderer, " RX 570 ") || strstr(renderer, " RX 580 ") ||
+        strstr(renderer, " RX 590 ") || strstr(renderer, " RX550/550 ") ||
+        strstr(renderer, " (TM) 520  ") || strstr(renderer, " (TM) 530  ") ||
+        strstr(renderer, " R5 ") || strstr(renderer, " R7 ") || strstr(renderer, " R9 ")) {
+      return true;
+    }
+  }
+  return false;
+}
 /* -------------------------------------------------------------------- */
 /** \name Platform
  * \{ */
@@ -137,6 +159,11 @@ void GLBackend::platform_init()
         GPG.support_level = GPU_SUPPORT_LEVEL_LIMITED;
       }
     }
+    if (GPU_type_matches(GPU_DEVICE_ATI, GPU_OS_ANY, GPU_DRIVER_OFFICIAL)) {
+      if (is_faulty_T82856_platform(version, renderer)) {
+        GPG.support_level = GPU_SUPPORT_LEVEL_LIMITED;
+      }
+    }
   }
   GPG.create_key(GPG.support_level, vendor, renderer, version);
   GPG.create_gpu_name(vendor, renderer, version);
@@ -272,20 +299,10 @@ static void detect_workarounds()
     GCaps.broken_amd_driver = true;
   }
   /* See T82856: AMD drivers since 20.11 running on a polaris architecture doesn't support the
-   * `GL_INT_2_10_10_10_REV` data type. This data type is used to pack normals. The work around
-   * uses `GPU_RGBA16I`.*/
+   * `GL_INT_2_10_10_10_REV` data type. */
   if (GPU_type_matches(GPU_DEVICE_ATI, GPU_OS_ANY, GPU_DRIVER_OFFICIAL)) {
-    /* On Linux the driver does not report its version. Test the OpenGL version in stead. */
-    if (strstr(version, "4.5.14756") || strstr(version, "4.5.14757")) {
-      if (strstr(renderer, " RX 460 ") || strstr(renderer, " RX 470 ") ||
-          strstr(renderer, " RX 480 ") || strstr(renderer, " RX 490 ") ||
-          strstr(renderer, " RX 560 ") || strstr(renderer, " RX 560X ") ||
-          strstr(renderer, " RX 570 ") || strstr(renderer, " RX 580 ") ||
-          strstr(renderer, " RX 590 ") || strstr(renderer, " RX550/550 ") ||
-          strstr(renderer, " (TM) 520  ") || strstr(renderer, " (TM) 530  ") ||
-          strstr(renderer, " R5 ") || strstr(renderer, " R7 ") || strstr(renderer, " R9 ")) {
-        GCaps.use_hq_normals_workaround = true;
-      }
+    if (is_faulty_T82856_platform(version, renderer)) {
+      GCaps.use_hq_normals_workaround = true;
     }
   }
   /* There is an issue with the #glBlitFramebuffer on MacOS with radeon pro graphics.
@@ -378,7 +395,7 @@ static void detect_workarounds()
   if (GLContext::debug_layer_support == false) {
     GLContext::debug_layer_workaround = true;
   }
-}
+}  // namespace blender::gpu
 
 /** Internal capabilities. */
 GLint GLContext::max_cubemap_size = 0;