[Bf-blender-cvs] [5370a7dd40a] master: Cleanup: use scale's 'space' argument instead of two transform calls
Campbell Barton
noreply at git.blender.org
Tue Jan 5 08:05:28 CET 2021
Commit: 5370a7dd40a9e45066e4db1e18ac93636765070f
Author: Campbell Barton
Date: Tue Jan 5 15:12:41 2021 +1100
Branches: master
https://developer.blender.org/rB5370a7dd40a9e45066e4db1e18ac93636765070f
Cleanup: use scale's 'space' argument instead of two transform calls
===================================================================
M source/blender/bmesh/operators/bmo_mirror.c
===================================================================
diff --git a/source/blender/bmesh/operators/bmo_mirror.c b/source/blender/bmesh/operators/bmo_mirror.c
index 88edc2fb59a..c0184a8c4c2 100644
--- a/source/blender/bmesh/operators/bmo_mirror.c
+++ b/source/blender/bmesh/operators/bmo_mirror.c
@@ -38,8 +38,6 @@ void bmo_mirror_exec(BMesh *bm, BMOperator *op)
BMOperator dupeop, weldop;
BMOIter siter;
BMVert *v;
- float mtx[4][4];
- float imtx[4][4];
float scale[3] = {1.0f, 1.0f, 1.0f};
float dist = BMO_slot_float_get(op->slots_in, "merge_dist");
int i;
@@ -50,9 +48,6 @@ void bmo_mirror_exec(BMesh *bm, BMOperator *op)
BMOpSlot *slot_targetmap;
BMOpSlot *slot_vertmap;
- BMO_slot_mat4_get(op->slots_in, "matrix", mtx);
- invert_m4_m4(imtx, mtx);
-
BMO_op_initf(bm, &dupeop, op->flag, "duplicate geom=%s", op, "geom");
BMO_op_exec(bm, &dupeop);
@@ -60,9 +55,7 @@ void bmo_mirror_exec(BMesh *bm, BMOperator *op)
/* feed old data to transform bmo */
scale[axis] = -1.0f;
- BMO_op_callf(bm, op->flag, "transform verts=%fv matrix=%m4", ELE_NEW, mtx);
- BMO_op_callf(bm, op->flag, "scale verts=%fv vec=%v", ELE_NEW, scale);
- BMO_op_callf(bm, op->flag, "transform verts=%fv matrix=%m4", ELE_NEW, imtx);
+ BMO_op_callf(bm, op->flag, "scale verts=%fv vec=%v space=%s", ELE_NEW, scale, op, "matrix");
BMO_op_init(bm, &weldop, op->flag, "weld_verts");
More information about the Bf-blender-cvs
mailing list