[Bf-blender-cvs] [52301ed53dc] temp-geometry-nodes-attribute-search: Add todo comment

Hans Goudey noreply at git.blender.org
Thu Feb 25 00:31:57 CET 2021


Commit: 52301ed53dcc43d11d972bf024318812254b79b2
Author: Hans Goudey
Date:   Wed Feb 24 17:30:16 2021 -0600
Branches: temp-geometry-nodes-attribute-search
https://developer.blender.org/rB52301ed53dcc43d11d972bf024318812254b79b2

Add todo comment

===================================================================

M	source/blender/editors/space_node/node_geometry_attribute_search.cc

===================================================================

diff --git a/source/blender/editors/space_node/node_geometry_attribute_search.cc b/source/blender/editors/space_node/node_geometry_attribute_search.cc
index 948c2b859d1..85cbe79550f 100644
--- a/source/blender/editors/space_node/node_geometry_attribute_search.cc
+++ b/source/blender/editors/space_node/node_geometry_attribute_search.cc
@@ -67,8 +67,8 @@ static void attribute_search_update_fn(const bContext *C,
   const Set<std::string> &attribute_name_hints = ui_storage->attribute_name_hints;
 
   if (str[0] != '\0') {
-    /* Any string may be valid, so add the current search string with the hints,
-     * but gray it out if if the attribute already exists. */
+    /* Any string may be valid, so add the current search string with the hints, but gray it out
+     * if the attribute already exists. TODO: Don't add this for input attributes. */
     const bool contains_search = attribute_name_hints.contains_as(StringRef(str));
     UI_search_item_add(
         items, str, (void *)str, ICON_ADD, contains_search ? UI_BUT_DISABLED : 0, 0);



More information about the Bf-blender-cvs mailing list