[Bf-blender-cvs] [43c43b8d480] temp-lineart-contained: Lineart: Fix memory leak in lineart_ops.c (Early return caused memory in list not freed).

YimingWu noreply at git.blender.org
Fri Feb 19 04:00:43 CET 2021


Commit: 43c43b8d48017ad9e34d43478403067be6fe8365
Author: YimingWu
Date:   Fri Feb 19 10:58:19 2021 +0800
Branches: temp-lineart-contained
https://developer.blender.org/rB43c43b8d48017ad9e34d43478403067be6fe8365

Lineart: Fix memory leak in lineart_ops.c (Early return caused memory in list not freed).

===================================================================

M	source/blender/gpencil_modifiers/intern/lineart/lineart_ops.c

===================================================================

diff --git a/source/blender/gpencil_modifiers/intern/lineart/lineart_ops.c b/source/blender/gpencil_modifiers/intern/lineart/lineart_ops.c
index ce3e02dd30c..61faa40336c 100644
--- a/source/blender/gpencil_modifiers/intern/lineart/lineart_ops.c
+++ b/source/blender/gpencil_modifiers/intern/lineart/lineart_ops.c
@@ -263,11 +263,9 @@ static int lineart_gpencil_clear_all_strokes_invoke(bContext *C,
                                                     wmOperator *op,
                                                     const wmEvent *UNUSED(event))
 {
-  // FIXME ASAN reports a mem leak here in CTX_DATA_BEGIN
-  // Yiming: I'm not sure why here it leaks... I'm taling a look.
   CTX_DATA_BEGIN (C, Object *, ob, visible_objects) {
     if (ob->type != OB_GPENCIL) {
-      return OPERATOR_CANCELLED;
+      continue;
     }
     LISTBASE_FOREACH (GpencilModifierData *, md, &ob->greasepencil_modifiers) {
       if (md->type != eGpencilModifierType_Lineart) {



More information about the Bf-blender-cvs mailing list