[Bf-blender-cvs] [2d3b29de4fc] blender-v2.92-release: Fix T85488: Display units inset operator

Falk David noreply at git.blender.org
Sun Feb 14 20:51:29 CET 2021


Commit: 2d3b29de4fc72d5e293deccd2317c001ede703e3
Author: Falk David
Date:   Tue Feb 9 10:33:21 2021 +0100
Branches: blender-v2.92-release
https://developer.blender.org/rB2d3b29de4fc72d5e293deccd2317c001ede703e3

Fix T85488: Display units inset operator

The inset operator would display the inset thickness and depth as
Blender units during transform. This meant that when the scene units
were set to something different than meters, the display value would
give different results than entering the same number using the value
input. (Similar to D10325)

The fix makes sure that the numbers are always displayed in the correct
scene units.

Reviewed By: campbellbarton

Maniphest Tasks: T85488

Differential Revision: https://developer.blender.org/D10366

===================================================================

M	source/blender/editors/mesh/editmesh_inset.c

===================================================================

diff --git a/source/blender/editors/mesh/editmesh_inset.c b/source/blender/editors/mesh/editmesh_inset.c
index 8427458d9cc..9000a942e50 100644
--- a/source/blender/editors/mesh/editmesh_inset.c
+++ b/source/blender/editors/mesh/editmesh_inset.c
@@ -97,9 +97,20 @@ static void edbm_inset_update_header(wmOperator *op, bContext *C)
       outputNumInput(&opdata->num_input, flts_str, &sce->unit);
     }
     else {
-      BLI_snprintf(flts_str, NUM_STR_REP_LEN, "%f", RNA_float_get(op->ptr, "thickness"));
-      BLI_snprintf(
-          flts_str + NUM_STR_REP_LEN, NUM_STR_REP_LEN, "%f", RNA_float_get(op->ptr, "depth"));
+      BKE_unit_value_as_string(flts_str,
+                               NUM_STR_REP_LEN,
+                               RNA_float_get(op->ptr, "thickness"),
+                               4,
+                               B_UNIT_LENGTH,
+                               &sce->unit,
+                               true);
+      BKE_unit_value_as_string(flts_str + NUM_STR_REP_LEN,
+                               NUM_STR_REP_LEN,
+                               RNA_float_get(op->ptr, "depth"),
+                               4,
+                               B_UNIT_LENGTH,
+                               &sce->unit,
+                               true);
     }
     BLI_snprintf(msg,
                  sizeof(msg),



More information about the Bf-blender-cvs mailing list