[Bf-blender-cvs] [fc3aa6b7ebe] pygpu_extensions: Fix T85558: crash changing the resolution mode of the "volume to mesh" node

Philipp Oeser noreply at git.blender.org
Fri Feb 12 16:17:21 CET 2021


Commit: fc3aa6b7ebe4580c1f0a875368160a2c51f021b8
Author: Philipp Oeser
Date:   Fri Feb 12 13:39:19 2021 +0100
Branches: pygpu_extensions
https://developer.blender.org/rBfc3aa6b7ebe4580c1f0a875368160a2c51f021b8

Fix T85558: crash changing the resolution mode of the "volume to mesh" node

The nodes update function geo_node_volume_to_mesh_update would not run
if it is not the very first node in the tree.
If the update function is not run, there are sockets not cleared from
the SOCK_UNAVAIL flag (but this needs to be done -- these get available
depending on the chosen mode).

Havent tracked down why this was actually updating when it was the first
node in the tree, but now make sure we always get an update by specifing
an appropriate RNA update callback for the property.

Maniphest Tasks: T85558

Differential Revision: https://developer.blender.org/D10403

===================================================================

M	source/blender/makesrna/intern/rna_nodetree.c

===================================================================

diff --git a/source/blender/makesrna/intern/rna_nodetree.c b/source/blender/makesrna/intern/rna_nodetree.c
index 610edb0e37c..3a9d373e30e 100644
--- a/source/blender/makesrna/intern/rna_nodetree.c
+++ b/source/blender/makesrna/intern/rna_nodetree.c
@@ -9029,6 +9029,7 @@ static void def_geo_volume_to_mesh(StructRNA *srna)
   prop = RNA_def_property(srna, "resolution_mode", PROP_ENUM, PROP_NONE);
   RNA_def_property_enum_items(prop, resolution_mode_items);
   RNA_def_property_ui_text(prop, "Resolution Mode", "How the voxel size is specified");
+  RNA_def_property_update(prop, NC_NODE | NA_EDITED, "rna_Node_socket_update");
 }
 
 static void def_geo_attribute_combine_xyz(StructRNA *srna)



More information about the Bf-blender-cvs mailing list