[Bf-blender-cvs] [87c75767b3b] master: Fixed (unreported) memleak in recent BMain relations new code.

Bastien Montagne noreply at git.blender.org
Tue Feb 9 21:57:14 CET 2021


Commit: 87c75767b3b4bba8b6cd6b147dbd475d9154e0ae
Author: Bastien Montagne
Date:   Tue Feb 9 21:38:57 2021 +0100
Branches: master
https://developer.blender.org/rB87c75767b3b4bba8b6cd6b147dbd475d9154e0ae

Fixed (unreported) memleak in recent BMain relations new code.

Forgot to free the GHash iterator.

===================================================================

M	source/blender/blenkernel/intern/main.c

===================================================================

diff --git a/source/blender/blenkernel/intern/main.c b/source/blender/blenkernel/intern/main.c
index d5cbcb62af2..6f94b3355fa 100644
--- a/source/blender/blenkernel/intern/main.c
+++ b/source/blender/blenkernel/intern/main.c
@@ -317,7 +317,9 @@ void BKE_main_relations_tag_set(struct Main *bmain,
   if (bmain->relations == NULL) {
     return;
   }
-  for (GHashIterator *gh_iter = BLI_ghashIterator_new(bmain->relations->relations_from_pointers);
+
+  GHashIterator *gh_iter;
+  for (gh_iter = BLI_ghashIterator_new(bmain->relations->relations_from_pointers);
        !BLI_ghashIterator_done(gh_iter);
        BLI_ghashIterator_step(gh_iter)) {
     MainIDRelationsEntry *entry = BLI_ghashIterator_getValue(gh_iter);
@@ -328,6 +330,7 @@ void BKE_main_relations_tag_set(struct Main *bmain,
       entry->tags &= ~tag;
     }
   }
+  BLI_ghashIterator_free(gh_iter);
 }
 
 /**



More information about the Bf-blender-cvs mailing list