[Bf-blender-cvs] [f45dac34e9e] usd-importer-T81257-merge: USD importer: vertex normals render black.

makowalski noreply at git.blender.org
Mon Feb 8 22:21:43 CET 2021


Commit: f45dac34e9e48166acb49593ca4e9e99d74c8e9c
Author: makowalski
Date:   Sat Feb 6 19:24:26 2021 -0500
Branches: usd-importer-T81257-merge
https://developer.blender.org/rBf45dac34e9e48166acb49593ca4e9e99d74c8e9c

USD importer: vertex normals render black.

Setting point normals by invoking normal_float_to_short_v3(),
instead of directly assigning components as floats.

===================================================================

M	source/blender/io/usd/intern/usd_reader_mesh.cc

===================================================================

diff --git a/source/blender/io/usd/intern/usd_reader_mesh.cc b/source/blender/io/usd/intern/usd_reader_mesh.cc
index 5d491e9beb4..75f666db1d1 100644
--- a/source/blender/io/usd/intern/usd_reader_mesh.cc
+++ b/source/blender/io/usd/intern/usd_reader_mesh.cc
@@ -488,9 +488,7 @@ void USDMeshReader::process_normals_vertex_varying(Mesh *mesh)
 {
   for (int i = 0; i < m_normals.size(); i++) {
     MVert &mvert = mesh->mvert[i];
-    mvert.no[0] = m_normals[i][0];
-    mvert.no[1] = m_normals[i][1];
-    mvert.no[2] = m_normals[i][2];
+    normal_float_to_short_v3(mvert.no, m_normals[i].data());
   }
 }



More information about the Bf-blender-cvs mailing list