[Bf-blender-cvs] [8eef5de9ba0] usd-importer-T81257-merge: USD importer: custom normals shading bug.

makowalski noreply at git.blender.org
Mon Feb 8 22:21:43 CET 2021


Commit: 8eef5de9ba0a8851cda7554fba65bc3a99574608
Author: makowalski
Date:   Fri Feb 5 22:48:43 2021 -0500
Branches: usd-importer-T81257-merge
https://developer.blender.org/rB8eef5de9ba0a8851cda7554fba65bc3a99574608

USD importer: custom normals shading bug.

Removed call to BKE_mesh_calc_edges() after setting
UVs, as this function is already called after setting
polys.  Moreover, the second, redundant call was causing
incorrect viewport shading of previously set custom
normals.  Now also setting the ME_AUTOSMOOTH mesh flag
to enable shading with custom normals.

===================================================================

M	source/blender/io/usd/intern/usd_reader_mesh.cc

===================================================================

diff --git a/source/blender/io/usd/intern/usd_reader_mesh.cc b/source/blender/io/usd/intern/usd_reader_mesh.cc
index 10aba6c99d8..5d491e9beb4 100644
--- a/source/blender/io/usd/intern/usd_reader_mesh.cc
+++ b/source/blender/io/usd/intern/usd_reader_mesh.cc
@@ -383,7 +383,6 @@ void USDMeshReader::read_uvs(Mesh *mesh,
       }
     }
   }
-  BKE_mesh_calc_edges(mesh, false, false);
 }
 
 void USDMeshReader::read_attributes(Mesh *mesh,
@@ -502,7 +501,7 @@ void USDMeshReader::process_normals_face_varying(Mesh *mesh)
     return;
   }
 
-  // mesh->flag |= ME_AUTOSMOOTH;
+  mesh->flag |= ME_AUTOSMOOTH;
 
   long int loop_count = m_normals.size();



More information about the Bf-blender-cvs mailing list