[Bf-blender-cvs] [f2bf5acd582] master: Keymap: use Shift-Tab to cycle backwards over edit-buttons

[Campbell Barton]

Commit: f2bf5acd5824673e4a7d641c833ec6940e6b5bea
Author: Campbell Barton
Date:   Fri Feb 5 16:44:42 2021 +1100
Branches: master
https://developer.blender.org/rBf2bf5acd5824673e4a7d641c833ec6940e6b5bea

Keymap: use Shift-Tab to cycle backwards over edit-buttons

All modifiers were being checked, a hang-over from 2.4x
where this checked the modifier flag was non-zero.

===================================================================

M	source/blender/editors/interface/interface_handlers.c

===================================================================

diff --git a/source/blender/editors/interface/interface_handlers.c b/source/blender/editors/interface/interface_handlers.c
index ba96b3ce31f..abe40f88ec6 100644
--- a/source/blender/editors/interface/interface_handlers.c
+++ b/source/blender/editors/interface/interface_handlers.c
@@ -3735,13 +3735,14 @@ static void ui_do_but_textedit(
             button_activate_state(C, but, BUTTON_STATE_EXIT);
           }
         }
-        /* the hotkey here is not well defined, was G.qual so we check all */
-        else if (IS_EVENT_MOD(event, shift, ctrl, alt, oskey)) {
-          ui_textedit_prev_but(block, but, data);
-          button_activate_state(C, but, BUTTON_STATE_EXIT);
-        }
-        else {
-          ui_textedit_next_but(block, but, data);
+        else if (!IS_EVENT_MOD(event, ctrl, alt, oskey)) {
+          /* Use standard keys for cycling through buttons Tab, Shift-Tab to reverse. */
+          if (event->shift) {
+            ui_textedit_prev_but(block, but, data);
+          }
+          else {
+            ui_textedit_next_but(block, but, data);
+          }
           button_activate_state(C, but, BUTTON_STATE_EXIT);
         }
         retval = WM_UI_HANDLER_BREAK;